fix(docker): Nuke ingestion containers when calling docker/nuke.sh #2459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shirshanka
reviewed
Apr 26, 2021
docker/nuke.sh
Outdated
| @@ -6,3 +6,7 @@ cd $DIR | |||
| # Tear down and clean up all DataHub-related containers, volumes, and network | |||
| docker-compose -p datahub down -v | |||
| docker-compose rm -f -v | |||
|
|
|||
| # Tear down ingestion container | |||
| cd ingestion | |||
There was a problem hiding this comment.
maybe (cd ingestion && docker-compose -p datahub down -v) ?
That way the script ends in the same directory?
added 2 commits
April 26, 2021 16:07
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current nuke.sh only destroys the containers created by the main docker-compose.yml files. Because ingestion uses a separate docker-compose.yml, these containers are not destroyed. As a result, when we bring up the containers again after nuking, the ingestion script fails as the container points to an old network instance. This change makes sure the ingestion containers are also nuked so that the above issue does not happen.
Checklist