Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add smoke test #2464

Merged
merged 43 commits into from
Apr 30, 2021
Merged

test: add smoke test #2464

merged 43 commits into from
Apr 30, 2021

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Apr 27, 2021

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

hsheth2 and others added 30 commits March 29, 2021 12:50
@hsheth2
add init smoke test
2ca2224
@hsheth2
use docker healthchecks in smoke test
c3d614e
@hsheth2
bump up healthcheck wait times
0f524c2
@hsheth2
enable github workflow
48ab55b
@hsheth2
bump retry count
8d5f2b5
@hsheth2
ensure pip wheels are used
dc8afe2
@hsheth2
bump retries
b8eecc2
@hsheth2
reduce check interval
058505e
@hsheth2
attempt docker-compose up twice
c66a802
@hsheth2
better logging in smoke test
977316f
@hsheth2
attempt up a couple times
30281fd
@hsheth2
fix logs command
6b23166
@hsheth2
add init smoke test
39c87d6
@hsheth2
use docker healthchecks in smoke test
88e32bd
@hsheth2
bump up healthcheck wait times
03458d4
@hsheth2
enable github workflow
27e9b50
@hsheth2
bump retry count
21e5ca6
@hsheth2
ensure pip wheels are used
b861dda
@hsheth2
bump retries
34cc921
@hsheth2
reduce check interval
17e6a40
@hsheth2
attempt docker-compose up twice
31bc840
@hsheth2
better logging in smoke test
b1bce7a
@hsheth2
attempt up a couple times
68fed6e
@hsheth2
fix logs command
aa9cad8
Merge remote-tracking branch 'origin/master' into smoketest
f2cfcd8
Merge branch 'smoketest' of https://github.com/acryldata/datahub-fork …
6970ef7 
…into smoketest
@hsheth2
Merge branch 'master' into smoketest
eaee51a
Add tmpfs
2f98311
Update workflow
b6d4fcd
Merge remote-tracking branch 'origin/master' into smoketest
00e2243
@hsheth2 hsheth2 changed the title [WIP] test: add smoketest test: add smoke test Apr 27, 2021
@hsheth2 hsheth2 marked this pull request as ready for review April 27, 2021 23:01
dexter-mh-lee
dexter-mh-lee approved these changes Apr 28, 2021
View reviewed changes
Copy link
Contributor

@dexter-mh-lee dexter-mh-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

shirshanka
shirshanka approved these changes Apr 30, 2021
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shirshanka shirshanka merged commit 201ffd4 into datahub-project:master Apr 30, 2021
@hsheth2 hsheth2 deleted the smoketest branch November 10, 2022 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirshanka shirshanka shirshanka approved these changes

@dexter-mh-lee dexter-mh-lee dexter-mh-lee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hsheth2 @dexter-mh-lee @shirshanka