Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fixed MCE file recipe example #2505

Merged
merged 2 commits into from
May 7, 2021
Merged

docs: fixed MCE file recipe example #2505

merged 2 commits into from
May 7, 2021

Conversation

vlavorini
Copy link
Contributor

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

vlavorini added 2 commits May 6, 2021 13:25
@vlavorini
Update README.md
17a22b6 
Corrected recipe for file metadata pulling
@vlavorini
docs: fixed File recipe example
b1eca39
hsheth2
hsheth2 approved these changes May 6, 2021
View reviewed changes
Copy link
Collaborator

@hsheth2 hsheth2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for fixing this!

shirshanka
shirshanka approved these changes May 7, 2021
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shirshanka shirshanka merged commit 3132910 into datahub-project:master May 7, 2021
jjoyce0510 pushed a commit to jjoyce0510/datahub-1 that referenced this pull request Jun 2, 2021
@vlavorini @jjoyce0510
docs: fixed MCE file recipe example (datahub-project#2505)
ea2d721
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsheth2 hsheth2 hsheth2 approved these changes

@shirshanka shirshanka shirshanka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vlavorini @shirshanka @hsheth2