Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update docusaurus #2515

Merged
merged 4 commits into from
May 11, 2021
Merged

docs: update docusaurus #2515

merged 4 commits into from
May 11, 2021

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented May 8, 2021

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@shirshanka
Copy link
Contributor

@hsheth2 CI seems to be unhappy?

@hsheth2
Copy link
Collaborator Author

hsheth2 commented May 10, 2021

@shirshanka CI should be fixed now

shirshanka
shirshanka approved these changes May 11, 2021
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shirshanka shirshanka merged commit 18ac4f3 into datahub-project:master May 11, 2021
@hsheth2 hsheth2 deleted the docusaurus-update branch February 12, 2022 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirshanka shirshanka shirshanka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hsheth2 @shirshanka