feat(ingest): kafka connect metadata ingestion #2516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taufiqibrahim
changed the title
taufiqibrahim
changed the title
hsheth2
requested changes
May 10, 2021
There was a problem hiding this comment.
This is awesome - thanks @taufiqibrahim!
Would love if you updated the README.md file with some basic docs, and also added some tests for this source 🙂
metadata-ingestion/src/datahub/ingestion/source/kafka_connect.py
Outdated
Show resolved
Hide resolved
|
|
||
| if connector_class in ('io.debezium.connector.vitess.VitessConnector'): | ||
| serverName = connector_config.get("database.server.name") | ||
| source_platform = 'vitess' |
There was a problem hiding this comment.
This bit seems super repetitive - any way we can extract this configuration into a table?
metadata-ingestion/src/datahub/ingestion/source/kafka_connect.py
Outdated
Show resolved
Hide resolved
metadata-ingestion/src/datahub/ingestion/source/kafka_connect.py
Outdated
Show resolved
Hide resolved
metadata-ingestion/src/datahub/ingestion/source/kafka_connect.py
Outdated
Show resolved
Hide resolved
metadata-ingestion/src/datahub/ingestion/source/kafka_connect.py
Outdated
Show resolved
Hide resolved
metadata-ingestion/src/datahub/ingestion/source/kafka_connect.py
Outdated
Show resolved
Hide resolved
|
Thanks @hsheth2 for your valuable feedback. Let me do the fixes |
…estion-kafkaconnect
…tion get_connectors_manifest()
|
Looks like some lint checks are failing. You can fix it via: |
Let me try this command. Thanks @shirshanka |
…uration using dicionary and few refactors
shirshanka
approved these changes
May 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
Metadata ingestion for Kafka Connect based on Kafka Connect REST API. Currently limited only for Debezium based source connectors. Sink connector not yet implemented.
Implementation summary:
DataFlowSnapshotandDataJobSnapshotentities