Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: autoplay and navigation for source logos carousel #2534

Merged
merged 16 commits into from
May 12, 2021
Merged

docs: autoplay and navigation for source logos carousel #2534

merged 16 commits into from
May 12, 2021

Conversation

kevinhu
Copy link
Contributor

@kevinhu kevinhu commented May 12, 2021 •
edited
Loading

Carousel automatically scrolls and has previous+next buttons for moving to next item. Also wraps back to first item when end is reached and adds Redshift logo.

Preview:
image

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@kevinhu kevinhu marked this pull request as ready for review May 12, 2021 00:43
shirshanka
shirshanka approved these changes May 12, 2021
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shirshanka shirshanka merged commit 5f673e6 into datahub-project:master May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirshanka shirshanka shirshanka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevinhu @shirshanka