Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(search): have search bar ignore blank searches #2556

Merged
merged 1 commit into from
May 14, 2021
Merged

fix(search): have search bar ignore blank searches #2556

merged 1 commit into from
May 14, 2021

Conversation

gabe-lyons
Copy link
Contributor

Followups:

  1. we should provide some guidance to users who attempt to do blank searches
  2. we should refactor search code so that we don't have search logic in 3 places.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@jjoyce0510
Copy link
Collaborator

lgtm! thanks gabe!

shirshanka
shirshanka approved these changes May 14, 2021
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shirshanka shirshanka merged commit 5de346b into datahub-project:master May 14, 2021
@shirshanka shirshanka mentioned this pull request May 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirshanka shirshanka shirshanka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gabe-lyons @jjoyce0510 @shirshanka