-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ingest): 🔒 - Add AWS IAM Roles Support to the Glue Source #2563
feat(ingest): 🔒 - Add AWS IAM Roles Support to the Glue Source #2563
Conversation
@shirshanka, I'm not sure why the tests are failing since they are unrelated to my PR 🤔 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM
The CI failure is due to mypy complaining about a typing issue:
> Task :metadata-ingestion:lint
src/datahub/ingestion/source/glue.py:100: error: Argument 3 to "reduce" has incompatible type "None"; expected "Dict[Any, Any]"
Found 1 error in 1 file (checked 138 source files)
But, with an |
Seems like your change should fix it 🎉 |
Yeap, fixed! :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This PR aims to add IAM Roles support to the existing Glue Source. This could allow importing the Glue Metadata cross AWS accounts by chaining roles or by allowing the current instance to assume an external role.
Checklist