Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ingest): 🔒 - Add AWS IAM Roles Support to the Glue Source #2563

Merged
merged 4 commits into from
May 17, 2021

Conversation

afranzi
Copy link
Contributor

@afranzi afranzi commented May 16, 2021

This PR aims to add IAM Roles support to the existing Glue Source. This could allow importing the Glue Metadata cross AWS accounts by chaining roles or by allowing the current instance to assume an external role.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@afranzi afranzi changed the title feat(ingestion): 🔒 - Add AWS IAM Roles Support to the Glue Source feat(ingest): 🔒 - Add AWS IAM Roles Support to the Glue Source May 16, 2021
@afranzi
Copy link
Contributor Author

afranzi commented May 17, 2021

@shirshanka, I'm not sure why the tests are failing since they are unrelated to my PR 🤔

Copy link
Collaborator

@hsheth2 hsheth2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

The CI failure is due to mypy complaining about a typing issue:

> Task :metadata-ingestion:lint
src/datahub/ingestion/source/glue.py:100: error: Argument 3 to "reduce" has incompatible type "None"; expected "Dict[Any, Any]"
Found 1 error in 1 file (checked 138 source files)

@afranzi
Copy link
Contributor Author

afranzi commented May 17, 2021

Code LGTM

The CI failure is due to mypy complaining about a typing issue:

> Task :metadata-ingestion:lint
src/datahub/ingestion/source/glue.py:100: error: Argument 3 to "reduce" has incompatible type "None"; expected "Dict[Any, Any]"
Found 1 error in 1 file (checked 138 source files)

But, with an credentials: Optional[dict] = None, shouldn't be possible to specify None? 🤔

@hsheth2
Copy link
Collaborator

hsheth2 commented May 17, 2021

Seems like your change should fix it 🎉

@afranzi
Copy link
Contributor Author

afranzi commented May 17, 2021

Seems like your change should fix it 🎉

Yeap, fixed! :)

Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shirshanka shirshanka merged commit 38e3f6d into datahub-project:master May 17, 2021
@afranzi afranzi deleted the ingestion/glue-roles branch May 17, 2021 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants