Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(bug) Update raw schema to show non json text #2566

Merged
merged 2 commits into from
May 17, 2021
Merged

(bug) Update raw schema to show non json text #2566

merged 2 commits into from
May 17, 2021

Conversation

saxo-lalrishav
Copy link
Contributor

@saxo-lalrishav saxo-lalrishav commented May 17, 2021 •
edited
Loading

Checklist

@saxo-lalrishav saxo-lalrishav changed the title 2565 | Update raw schema to show non json text (bug) Update raw schema to show non json text May 17, 2021
gabe-lyons
gabe-lyons approved these changes May 17, 2021
View reviewed changes
Copy link
Contributor

@gabe-lyons gabe-lyons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good- thanks for the fix @saxo-lalrishav

shirshanka
shirshanka approved these changes May 17, 2021
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the fix @saxo-lalrishav

@shirshanka shirshanka merged commit 8659dc3 into datahub-project:master May 17, 2021
@saxo-lalrishav saxo-lalrishav mentioned this pull request May 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabe-lyons gabe-lyons gabe-lyons approved these changes

@shirshanka shirshanka shirshanka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@saxo-lalrishav @shirshanka @gabe-lyons