Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(ingest): add a guide for writing sources #2575

Merged
merged 4 commits into from
May 24, 2021

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented May 18, 2021

Also upgrade docusaurus and fix some site generation bugs.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

hsheth2 added 2 commits May 17, 2021 18:46
Also upgrade docusaurus and fix some site generation bugs.
@shirshanka
Copy link
Contributor

@hsheth2 : looks like you need to rebase this

Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shirshanka shirshanka merged commit deca4a5 into datahub-project:master May 24, 2021
@hsheth2 hsheth2 deleted the sources-docs branch November 10, 2022 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants