feat(react): add configurable logo aspect ratio

[martha]

Checklist

• The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
• Links to related issues (if applicable)
• Tests for the changes have been added/updated (if applicable)
• Docs related to the changes have been added/updated (if applicable)

[gabe-lyons]

Great! Thanks for this contribution @martha. Could I ask you to also update src/app/home/HomePageHeader.tsx (the other location the logo image is rendered) and make sure it also respects the aspect ratio?

[martha]

@gabe-lyons good suggestion! The logo wasn't looking distorted on the home page, which is why I didn't update that file. I noticed that in src/app/home/HomePageHeader.tsx it specifies only a width, no height, for the logo image.

That makes me wonder whether the whole aspect ratio approach I outlined here is overthinking. Should I just modify SearchHeader.tsx to specify a height (32px) but no width?

[martha]

Homepage before

Homepage after this PR - it's the same

Search page before - distorted

Search page after - distortion fixed

edit - fixed image order

[gabe-lyons]

@martha I like your suggestion to fix the height of the search icon and let the width flex- this keeps the theme simpler. Let's go with that 👍

[martha]

Sure! Here's an updated screen shot after the new commit.

[shirshanka]

LGTM. Thanks @martha :)