feat(entities): add markdown description update/viewer feature in dataset, datajob, dataflow, chart and dashboard, update ui/ux

datahub-graphql-core/src/main/java/com/linkedin/datahub/graphql/types/chart/mappers/ChartSnapshotMapper.java

@@ -8,6 +8,7 @@
 import com.linkedin.datahub.graphql.generated.ChartType;
 import com.linkedin.datahub.graphql.generated.Dataset;
 import com.linkedin.datahub.graphql.generated.EntityType;
+import com.linkedin.datahub.graphql.generated.ChartEditableProperties;
 import com.linkedin.datahub.graphql.types.common.mappers.AuditStampMapper;
 import com.linkedin.datahub.graphql.types.common.mappers.StringMapMapper;
 import com.linkedin.datahub.graphql.types.tag.mappers.GlobalTagsMapper;
@@ -49,6 +50,10 @@ public Chart apply(@Nonnull final ChartSnapshot chart) {
                 result.setStatus(StatusMapper.map(aspect.getStatus()));
             } else if (aspect.isGlobalTags()) {
                 result.setGlobalTags(GlobalTagsMapper.map(aspect.getGlobalTags()));
+            } else if (aspect.isEditableChartProperties()) {
+                final ChartEditableProperties chartEditableProperties = new ChartEditableProperties();
+                chartEditableProperties.setDescription(aspect.getEditableChartProperties().getDescription());
+                result.setEditableProperties(chartEditableProperties);
             } else {
                 // throw new RuntimeException(String.format("Unrecognized aspect %s returned", aspect.toString()));
             }

datahub-graphql-core/src/main/java/com/linkedin/datahub/graphql/types/chart/mappers/ChartUpdateInputMapper.java

@@ -1,5 +1,6 @@
 package com.linkedin.datahub.graphql.types.chart.mappers;
 
+import com.linkedin.chart.EditableChartProperties;
 import com.linkedin.common.GlobalTags;
 import com.linkedin.common.TagAssociationArray;
 import com.linkedin.common.urn.Urn;
@@ -40,6 +41,12 @@ public Chart apply(@Nonnull final ChartUpdateInput chartUpdateInput,
             );
             result.setGlobalTags(globalTags);
         }
+
+        if (chartUpdateInput.getEditableProperties() != null) {
+            final EditableChartProperties editableChartProperties = new EditableChartProperties();
+            editableChartProperties.setDescription(chartUpdateInput.getEditableProperties().getDescription());
+            result.setEditableProperties(editableChartProperties);
+        }
         return result;
     }
 

datahub-graphql-core/src/main/java/com/linkedin/datahub/graphql/types/chart/mappers/ChartUpdateInputSnapshotMapper.java

@@ -1,9 +1,12 @@
 package com.linkedin.datahub.graphql.types.chart.mappers;
 
+import com.linkedin.common.AuditStamp;
 import com.linkedin.common.GlobalTags;
 import com.linkedin.common.TagAssociationArray;
 import com.linkedin.common.urn.ChartUrn;
 import com.linkedin.common.urn.Urn;
+import com.linkedin.chart.EditableChartProperties;
+import com.linkedin.data.template.SetMode;
 import com.linkedin.datahub.graphql.generated.ChartUpdateInput;
 import com.linkedin.datahub.graphql.types.common.mappers.OwnershipUpdateMapper;
 import com.linkedin.datahub.graphql.types.mappers.InputModelMapper;
@@ -29,7 +32,9 @@ public static ChartSnapshot map(@Nonnull final ChartUpdateInput chartUpdateInput
     public ChartSnapshot apply(@Nonnull final ChartUpdateInput chartUpdateInput,
                                @Nonnull final Urn actor) {
         final ChartSnapshot result = new ChartSnapshot();
-
+        final AuditStamp auditStamp = new AuditStamp();
+        auditStamp.setActor(actor, SetMode.IGNORE_NULL);
+        auditStamp.setTime(System.currentTimeMillis());
         try {
             result.setUrn(ChartUrn.createFromString(chartUpdateInput.getUrn()));
         } catch (URISyntaxException e) {
@@ -54,6 +59,16 @@ public ChartSnapshot apply(@Nonnull final ChartUpdateInput chartUpdateInput,
             aspects.add(ChartAspect.create(globalTags));
         }
 
+        if (chartUpdateInput.getEditableProperties() != null) {
+            final EditableChartProperties editableChartProperties = new EditableChartProperties();
+            editableChartProperties.setDescription(chartUpdateInput.getEditableProperties().getDescription());
+            if (!editableChartProperties.hasCreated()) {
+                editableChartProperties.setCreated(auditStamp);
+            }
+            editableChartProperties.setLastModified(auditStamp);
+            aspects.add(ChartAspect.create(editableChartProperties));
+        }
+
         result.setAspects(aspects);
 
         return result;

datahub-graphql-core/src/main/java/com/linkedin/datahub/graphql/types/dashboard/mappers/DashboardMapper.java

@@ -5,6 +5,7 @@
 import com.linkedin.datahub.graphql.generated.Dashboard;
 import com.linkedin.datahub.graphql.generated.DashboardInfo;
 import com.linkedin.datahub.graphql.generated.EntityType;
+import com.linkedin.datahub.graphql.generated.DashboardEditableProperties;
 import com.linkedin.datahub.graphql.types.common.mappers.AuditStampMapper;
 import com.linkedin.datahub.graphql.types.common.mappers.StringMapMapper;
 import com.linkedin.datahub.graphql.types.mappers.ModelMapper;
@@ -42,6 +43,11 @@ public Dashboard apply(@Nonnull final com.linkedin.dashboard.Dashboard dashboard
         if (dashboard.hasGlobalTags()) {
             result.setGlobalTags(GlobalTagsMapper.map(dashboard.getGlobalTags()));
         }
+        if (dashboard.hasEditableProperties()) {
+            final DashboardEditableProperties dashboardEditableProperties = new DashboardEditableProperties();
+            dashboardEditableProperties.setDescription(dashboard.getEditableProperties().getDescription());
+            result.setEditableProperties(dashboardEditableProperties);
+        }
         return result;
     }
 

datahub-graphql-core/src/main/java/com/linkedin/datahub/graphql/types/dashboard/mappers/DashboardSnapshotMapper.java

@@ -3,11 +3,13 @@
 import com.linkedin.common.GlobalTags;
 import com.linkedin.common.Ownership;
 import com.linkedin.common.Status;
+import com.linkedin.dashboard.EditableDashboardProperties;
 import com.linkedin.datahub.graphql.generated.AccessLevel;
 import com.linkedin.datahub.graphql.generated.Chart;
 import com.linkedin.datahub.graphql.generated.Dashboard;
 import com.linkedin.datahub.graphql.generated.DashboardInfo;
 import com.linkedin.datahub.graphql.generated.EntityType;
+import com.linkedin.datahub.graphql.generated.DashboardEditableProperties;
 import com.linkedin.datahub.graphql.types.common.mappers.AuditStampMapper;
 import com.linkedin.datahub.graphql.types.common.mappers.OwnershipMapper;
 import com.linkedin.datahub.graphql.types.common.mappers.StatusMapper;
@@ -48,6 +50,10 @@ public Dashboard apply(@Nonnull final DashboardSnapshot dashboard) {
                 result.setStatus(StatusMapper.map(status));
             } else if (aspect instanceof GlobalTags) {
                 result.setGlobalTags(GlobalTagsMapper.map(GlobalTags.class.cast(aspect)));
+            } else if (aspect instanceof EditableDashboardProperties) {
+                final DashboardEditableProperties dashboardEditableProperties = new DashboardEditableProperties();
+                dashboardEditableProperties.setDescription(((EditableDashboardProperties) aspect).getDescription());
+                result.setEditableProperties(dashboardEditableProperties);
             }
         });
         return result;

datahub-graphql-core/src/main/java/com/linkedin/datahub/graphql/types/dashboard/mappers/DashboardUpdateInputMapper.java

@@ -4,6 +4,7 @@
 import com.linkedin.common.TagAssociationArray;
 import com.linkedin.common.urn.Urn;
 import com.linkedin.dashboard.Dashboard;
+import com.linkedin.dashboard.EditableDashboardProperties;
 import com.linkedin.datahub.graphql.generated.DashboardUpdateInput;
 import com.linkedin.datahub.graphql.types.common.mappers.OwnershipUpdateMapper;
 import com.linkedin.datahub.graphql.types.mappers.InputModelMapper;
@@ -40,6 +41,12 @@ public Dashboard apply(@Nonnull final DashboardUpdateInput dashboardUpdateInput,
             );
             result.setGlobalTags(globalTags);
         }
+
+        if (dashboardUpdateInput.getEditableProperties() != null) {
+            final EditableDashboardProperties editableDashboardProperties = new EditableDashboardProperties();
+            editableDashboardProperties.setDescription(dashboardUpdateInput.getEditableProperties().getDescription());
+            result.setEditableProperties(editableDashboardProperties);
+        }
         return result;
     }
 

datahub-graphql-core/src/main/java/com/linkedin/datahub/graphql/types/dashboard/mappers/DashboardUpdateInputSnapshotMapper.java

@@ -1,16 +1,20 @@
 package com.linkedin.datahub.graphql.types.dashboard.mappers;
 
+import com.linkedin.common.AuditStamp;
 import com.linkedin.common.GlobalTags;
 
 import com.linkedin.common.TagAssociationArray;
 import com.linkedin.common.urn.DashboardUrn;
 import com.linkedin.common.urn.Urn;
+import com.linkedin.dashboard.EditableDashboardProperties;
+import com.linkedin.data.template.SetMode;
 import com.linkedin.datahub.graphql.generated.DashboardUpdateInput;
 import com.linkedin.datahub.graphql.types.common.mappers.OwnershipUpdateMapper;
 import com.linkedin.datahub.graphql.types.mappers.InputModelMapper;
 import com.linkedin.datahub.graphql.types.tag.mappers.TagAssociationUpdateMapper;
 import com.linkedin.metadata.aspect.DashboardAspect;
 import com.linkedin.metadata.aspect.DashboardAspectArray;
+import com.linkedin.metadata.dao.utils.ModelUtils;
 import com.linkedin.metadata.snapshot.DashboardSnapshot;
 import java.net.URISyntaxException;
 import java.util.stream.Collectors;
@@ -29,6 +33,9 @@ public static DashboardSnapshot map(@Nonnull final DashboardUpdateInput dashboar
     public DashboardSnapshot apply(@Nonnull final DashboardUpdateInput dashboardUpdateInput,
                            @Nonnull final Urn actor) {
         final DashboardSnapshot result = new DashboardSnapshot();
+        final AuditStamp auditStamp = new AuditStamp();
+        auditStamp.setActor(actor, SetMode.IGNORE_NULL);
+        auditStamp.setTime(System.currentTimeMillis());
 
         try {
             result.setUrn(DashboardUrn.createFromString(dashboardUpdateInput.getUrn()));
@@ -55,6 +62,16 @@ public DashboardSnapshot apply(@Nonnull final DashboardUpdateInput dashboardUpda
             aspects.add(DashboardAspect.create(globalTags));
         }
 
+        if (dashboardUpdateInput.getEditableProperties() != null) {
+            final EditableDashboardProperties editableDashboardProperties = new EditableDashboardProperties();
+            editableDashboardProperties.setDescription(dashboardUpdateInput.getEditableProperties().getDescription());
+            if (!editableDashboardProperties.hasCreated()) {
+                editableDashboardProperties.setCreated(auditStamp);
+            }
+            editableDashboardProperties.setLastModified(auditStamp);
+            aspects.add(ModelUtils.newAspectUnion(DashboardAspect.class, editableDashboardProperties));
+        }
+
         result.setAspects(aspects);
 
         return result;

datahub-graphql-core/src/main/java/com/linkedin/datahub/graphql/types/dataflow/DataFlowType.java

@@ -170,6 +170,9 @@ protected DataFlowSnapshot toSnapshot(@Nonnull com.linkedin.datajob.DataFlow dat
         if (dataFlow.hasGlobalTags()) {
             aspects.add(ModelUtils.newAspectUnion(DataFlowAspect.class, dataFlow.getGlobalTags()));
         }
+        if (dataFlow.hasEditableProperties()) {
+            aspects.add(ModelUtils.newAspectUnion(DataFlowAspect.class, dataFlow.getEditableProperties()));
+        }
         return ModelUtils.newSnapshot(DataFlowSnapshot.class, urn, aspects);
     }
 

datahub-graphql-core/src/main/java/com/linkedin/datahub/graphql/types/dataflow/mappers/DataFlowSnapshotMapper.java

@@ -4,13 +4,15 @@
 import com.linkedin.common.Ownership;
 import com.linkedin.common.Status;
 import com.linkedin.datahub.graphql.generated.DataFlow;
+import com.linkedin.datahub.graphql.generated.DataFlowEditableProperties;
 import com.linkedin.datahub.graphql.generated.DataFlowInfo;
 import com.linkedin.datahub.graphql.generated.EntityType;
 import com.linkedin.datahub.graphql.types.common.mappers.OwnershipMapper;
 import com.linkedin.datahub.graphql.types.common.mappers.StatusMapper;
 import com.linkedin.datahub.graphql.types.common.mappers.StringMapMapper;
 import com.linkedin.datahub.graphql.types.mappers.ModelMapper;
 import com.linkedin.datahub.graphql.types.tag.mappers.GlobalTagsMapper;
+import com.linkedin.datajob.EditableDataflowProperties;
 import com.linkedin.metadata.dao.utils.ModelUtils;
 import com.linkedin.metadata.snapshot.DataFlowSnapshot;
 import javax.annotation.Nonnull;
@@ -45,6 +47,10 @@ public DataFlow apply(@Nonnull final DataFlowSnapshot dataflow) {
                 result.setStatus(StatusMapper.map(status));
             } else if (aspect instanceof GlobalTags) {
                 result.setGlobalTags(GlobalTagsMapper.map(GlobalTags.class.cast(aspect)));
+            } else if (aspect instanceof EditableDataflowProperties) {
+                final DataFlowEditableProperties dataFlowEditableProperties = new DataFlowEditableProperties();
+                dataFlowEditableProperties.setDescription(((EditableDataflowProperties) aspect).getDescription());
+                result.setEditableProperties(dataFlowEditableProperties);
             }
         });
         return result;

datahub-graphql-core/src/main/java/com/linkedin/datahub/graphql/types/dataflow/mappers/DataFlowUpdateInputMapper.java

@@ -1,13 +1,16 @@
 package com.linkedin.datahub.graphql.types.dataflow.mappers;
 
+import com.linkedin.common.AuditStamp;
 import com.linkedin.common.GlobalTags;
 import com.linkedin.common.TagAssociationArray;
 import com.linkedin.common.urn.Urn;
+import com.linkedin.data.template.SetMode;
 import com.linkedin.datahub.graphql.generated.DataFlowUpdateInput;
 import com.linkedin.datahub.graphql.types.common.mappers.OwnershipUpdateMapper;
 import com.linkedin.datahub.graphql.types.mappers.InputModelMapper;
 import com.linkedin.datahub.graphql.types.tag.mappers.TagAssociationUpdateMapper;
 import com.linkedin.datajob.DataFlow;
+import com.linkedin.datajob.EditableDataflowProperties;
 
 import javax.annotation.Nonnull;
 import java.util.stream.Collectors;
@@ -24,6 +27,9 @@ public static DataFlow map(@Nonnull final DataFlowUpdateInput dataFlowUpdateInpu
     public DataFlow apply(@Nonnull final DataFlowUpdateInput dataFlowUpdateInput,
                           @Nonnull final Urn actor) {
         final DataFlow result = new DataFlow();
+        final AuditStamp auditStamp = new AuditStamp();
+        auditStamp.setActor(actor, SetMode.IGNORE_NULL);
+        auditStamp.setTime(System.currentTimeMillis());
 
         if (dataFlowUpdateInput.getOwnership() != null) {
             result.setOwnership(OwnershipUpdateMapper.map(dataFlowUpdateInput.getOwnership(), actor));
@@ -40,6 +46,16 @@ public DataFlow apply(@Nonnull final DataFlowUpdateInput dataFlowUpdateInput,
             );
             result.setGlobalTags(globalTags);
         }
+
+        if (dataFlowUpdateInput.getEditableProperties() != null) {
+            final EditableDataflowProperties editableDataflowProperties = new EditableDataflowProperties();
+            editableDataflowProperties.setDescription(dataFlowUpdateInput.getEditableProperties().getDescription());
+            if (!editableDataflowProperties.hasCreated()) {
+                editableDataflowProperties.setCreated(auditStamp);
+            }
+            editableDataflowProperties.setLastModified(auditStamp);
+            result.setEditableProperties(editableDataflowProperties);
+        }
         return result;
     }
 }

datahub-graphql-core/src/main/java/com/linkedin/datahub/graphql/types/datajob/DataJobType.java

@@ -175,6 +175,9 @@ public static DataJobSnapshot toSnapshot(@Nonnull com.linkedin.datajob.DataJob d
         if (dataJob.hasGlobalTags()) {
             aspects.add(ModelUtils.newAspectUnion(DataJobAspect.class, dataJob.getGlobalTags()));
         }
+        if (dataJob.hasEditableProperties()) {
+            aspects.add(ModelUtils.newAspectUnion(DataJobAspect.class, dataJob.getEditableProperties()));
+        }
         return ModelUtils.newSnapshot(DataJobSnapshot.class, urn, aspects);
     }
 
@@ -186,7 +189,7 @@ public DataJob update(@Nonnull DataJobUpdateInput input, @Nonnull QueryContext c
 
         try {
             Entity entity = new Entity();
-            entity.setValue(Snapshot.create(toSnapshot(partialDataJob, partialDataJob.getUrn())));
+            entity.setValue(Snapshot.create(toSnapshot(partialDataJob, DataJobUrn.createFromString(input.getUrn()))));
             _dataJobsClient.update(entity);
         } catch (RemoteInvocationException e) {
             throw new RuntimeException(String.format("Failed to write entity with urn %s", input.getUrn()), e);

datahub-graphql-core/src/main/java/com/linkedin/datahub/graphql/types/datajob/mappers/DataJobSnapshotMapper.java

@@ -10,11 +10,13 @@
 import com.linkedin.datahub.graphql.generated.DataJobInputOutput;
 import com.linkedin.datahub.graphql.generated.Dataset;
 import com.linkedin.datahub.graphql.generated.EntityType;
+import com.linkedin.datahub.graphql.generated.DataJobEditableProperties;
 import com.linkedin.datahub.graphql.types.common.mappers.OwnershipMapper;
 import com.linkedin.datahub.graphql.types.common.mappers.StatusMapper;
 import com.linkedin.datahub.graphql.types.common.mappers.StringMapMapper;
 import com.linkedin.datahub.graphql.types.mappers.ModelMapper;
 import com.linkedin.datahub.graphql.types.tag.mappers.GlobalTagsMapper;
+import com.linkedin.datajob.EditableDatajobProperties;
 import com.linkedin.metadata.dao.utils.ModelUtils;
 import com.linkedin.metadata.snapshot.DataJobSnapshot;
 import java.util.stream.Collectors;
@@ -52,6 +54,10 @@ public DataJob apply(@Nonnull final DataJobSnapshot dataJob) {
                 result.setStatus(StatusMapper.map(status));
             } else if (aspect instanceof GlobalTags) {
                 result.setGlobalTags(GlobalTagsMapper.map(GlobalTags.class.cast(aspect)));
+            } else if (aspect instanceof EditableDatajobProperties) {
+                final DataJobEditableProperties dataJobEditableProperties = new DataJobEditableProperties();
+                dataJobEditableProperties.setDescription(((EditableDatajobProperties) aspect).getDescription());
+                result.setEditableProperties(dataJobEditableProperties);
             }
         });
 

datahub-graphql-core/src/main/java/com/linkedin/datahub/graphql/types/datajob/mappers/DataJobUpdateInputMapper.java

@@ -1,13 +1,16 @@
 package com.linkedin.datahub.graphql.types.datajob.mappers;
 
+import com.linkedin.common.AuditStamp;
 import com.linkedin.common.GlobalTags;
 import com.linkedin.common.TagAssociationArray;
 import com.linkedin.common.urn.Urn;
+import com.linkedin.data.template.SetMode;
 import com.linkedin.datahub.graphql.generated.DataJobUpdateInput;
 import com.linkedin.datahub.graphql.types.common.mappers.OwnershipUpdateMapper;
 import com.linkedin.datahub.graphql.types.mappers.InputModelMapper;
 import com.linkedin.datahub.graphql.types.tag.mappers.TagAssociationUpdateMapper;
 import com.linkedin.datajob.DataJob;
+import com.linkedin.datajob.EditableDatajobProperties;
 
 import javax.annotation.Nonnull;
 import java.util.stream.Collectors;
@@ -24,7 +27,9 @@ public static DataJob map(@Nonnull final DataJobUpdateInput dataJobUpdateInput,
     public DataJob apply(@Nonnull final DataJobUpdateInput dataJobUpdateInput,
                          @Nonnull final Urn actor) {
         final DataJob result = new DataJob();
-
+        final AuditStamp auditStamp = new AuditStamp();
+        auditStamp.setActor(actor, SetMode.IGNORE_NULL);
+        auditStamp.setTime(System.currentTimeMillis());
         if (dataJobUpdateInput.getOwnership() != null) {
             result.setOwnership(OwnershipUpdateMapper.map(dataJobUpdateInput.getOwnership(), actor));
         }
@@ -40,6 +45,16 @@ public DataJob apply(@Nonnull final DataJobUpdateInput dataJobUpdateInput,
             );
             result.setGlobalTags(globalTags);
         }
+
+        if (dataJobUpdateInput.getEditableProperties() != null) {
+            final EditableDatajobProperties editableDatajobProperties = new EditableDatajobProperties();
+            editableDatajobProperties.setDescription(dataJobUpdateInput.getEditableProperties().getDescription());
+            if (!editableDatajobProperties.hasCreated()) {
+                editableDatajobProperties.setCreated(auditStamp);
+            }
+            editableDatajobProperties.setLastModified(auditStamp);
+            result.setEditableProperties(editableDatajobProperties);
+        }
         return result;
     }
 }

datahub-graphql-core/src/main/java/com/linkedin/datahub/graphql/types/datajob/mappers/DataJobUpdateInputSnapshotMapper.java

@@ -8,6 +8,8 @@
 import com.linkedin.datahub.graphql.types.mappers.InputModelMapper;
 import com.linkedin.datahub.graphql.types.tag.mappers.TagAssociationUpdateMapper;
 import com.linkedin.datajob.DataJob;
+import com.linkedin.datajob.EditableDatajobProperties;
+
 import java.util.stream.Collectors;
 import javax.annotation.Nonnull;
 
@@ -40,6 +42,12 @@ public DataJob apply(@Nonnull final DataJobUpdateInput dataJobUpdateInput,
             );
             result.setGlobalTags(globalTags);
         }
+
+        if (dataJobUpdateInput.getEditableProperties() != null) {
+            final EditableDatajobProperties editableDatajobProperties = new EditableDatajobProperties();
+            editableDatajobProperties.setDescription(dataJobUpdateInput.getEditableProperties().getDescription());
+            result.setEditableProperties(editableDatajobProperties);
+        }
         return result;
     }
 }