Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ingest): use trino python client for sqlalchemy, supports python… #3888

Merged
merged 1 commit into from
Jan 31, 2022
Merged

feat(ingest): use trino python client for sqlalchemy, supports python… #3888

merged 1 commit into from
Jan 31, 2022

Conversation

mayurinehate
Copy link
Collaborator

… 3.6

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@github-actions
Copy link

github-actions bot commented Jan 14, 2022 •
edited
Loading

Unit Test Results (build & test)

  66 files  ±0    66 suites  ±0   9m 2s ⏱️ - 4m 3s
581 tests ±0  522 ✔️ ±0  59 💤 ±0  0 ❌ ±0 

Results for commit 1a7103b. ± Comparison against base commit c27f1f9.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Jan 14, 2022 •
edited
Loading

Unit Test Results (metadata ingestion)

       5 files  ±0         5 suites  ±0   44m 55s ⏱️ + 8m 31s
   277 tests ±0     277 ✔️ +  1    0 💤 ±0  0 ❌  - 1 
1 274 runs  +6  1 245 ✔️ +15  29 💤  - 8  0 ❌  - 1 

Results for commit 1a7103b. ± Comparison against base commit c27f1f9.

♻️ This comment has been updated with latest results.

@mayurinehate mayurinehate marked this pull request as ready for review January 18, 2022 08:09
@mayurinehate mayurinehate force-pushed the use_trino_client_sqlalchemy branch from 7cce3b2 to 1a7103b Compare January 31, 2022 10:00
shirshanka
shirshanka approved these changes Jan 31, 2022
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shirshanka shirshanka merged commit faac911 into datahub-project:master Jan 31, 2022
@mayurinehate mayurinehate deleted the use_trino_client_sqlalchemy branch April 6, 2022 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirshanka shirshanka shirshanka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mayurinehate @shirshanka