Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ingest): support for Avro data lake files #3913

Merged
merged 7 commits into from
Jan 26, 2022
Merged

feat(ingest): support for Avro data lake files #3913

merged 7 commits into from
Jan 26, 2022

Conversation

kevinhu
Copy link
Contributor

@kevinhu kevinhu commented Jan 18, 2022 •
edited
Loading

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@github-actions
Copy link

github-actions bot commented Jan 19, 2022 •
edited
Loading

Unit Test Results (build & test)

  45 files  ±0    45 suites  ±0   13m 39s ⏱️ - 1m 32s
504 tests ±0  448 ✔️ ±0  56 💤 ±0  0 ❌ ±0 

Results for commit f2666b4. ± Comparison against base commit 3d12531.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Jan 19, 2022 •
edited
Loading

Unit Test Results (metadata ingestion)

       5 files         5 suites   38m 3s ⏱️
   274 tests    274 ✔️   0 💤 0 ❌
1 259 runs  1 225 ✔️ 34 💤 0 ❌

Results for commit f2666b4.

♻️ This comment has been updated with latest results.

@kevinhu kevinhu marked this pull request as ready for review January 19, 2022 02:10
anshbansal
anshbansal reviewed Jan 19, 2022
View reviewed changes
metadata-ingestion/src/datahub/ingestion/source/data_lake/__init__.py Outdated
file,
"To ingest avro files, please install the spark-avro package: https://mvnrepository.com/artifact/org.apache.spark/spark-avro_2.12/3.0.3",
)
raise (e)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not raise exception instead return None. Raising exception will cause outer loop to exit. But in our sources we would want to skip things and report failures instead of stopping the whole process

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

shirshanka
shirshanka approved these changes Jan 26, 2022
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shirshanka shirshanka merged commit 62f7d05 into datahub-project:master Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anshbansal anshbansal anshbansal left review comments

@shirshanka shirshanka shirshanka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kevinhu @shirshanka @anshbansal