Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ingestion): don't dump variables for config errors #3974

Merged
merged 2 commits into from
Jan 26, 2022

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Jan 26, 2022

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@github-actions
Copy link

github-actions bot commented Jan 26, 2022

Unit Test Results (build & test)

  45 files  ±0    45 suites  ±0   16m 34s ⏱️ + 2m 23s
505 tests ±0  449 ✔️ ±0  56 💤 ±0  0 ±0 

Results for commit 386b4eb. ± Comparison against base commit cec541d.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Jan 26, 2022

Unit Test Results (metadata ingestion)

       5 files  ±0         5 suites  ±0   36m 19s ⏱️ -40s
   274 tests ±0     273 ✔️ ±0    0 💤 ±0  1 ±0 
1 261 runs  +2  1 232 ✔️ +8  28 💤  - 6  1 ±0 

For more details on these failures, see this check.

Results for commit 386b4eb. ± Comparison against base commit cec541d.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@jjoyce0510 jjoyce0510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Were you able to verify this locally?

@hsheth2
Copy link
Collaborator Author

hsheth2 commented Jan 26, 2022

I was able to verify that it works locally - made one of the config validators throw an exception to test it.

However I think the approach is a bit ugly (particularly the SensitiveError.get_sensitive_cause() method) so open to suggestions/improvements

Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shirshanka shirshanka merged commit e6060c0 into datahub-project:master Jan 26, 2022
@hsheth2 hsheth2 deleted the sensitive-errors branch December 15, 2022 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants