Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ingest): remove unused groupby_unsorted utility #4011

Merged
merged 2 commits into from
Feb 11, 2022

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Jan 29, 2022

It was previously used by the profiler but is no longer necessary.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@github-actions
Copy link

github-actions bot commented Jan 29, 2022

Unit Test Results (build & test)

  66 files  ±0    66 suites  ±0   9m 40s ⏱️ - 1m 21s
582 tests ±0  522 ✔️  - 1  59 💤 ±0  1 +1 

For more details on these failures, see this check.

Results for commit 7ac248b. ± Comparison against base commit 697eda7.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Jan 30, 2022

Unit Test Results (metadata ingestion)

       5 files  ±0         5 suites  ±0   39m 54s ⏱️ -38s
   276 tests  - 1     276 ✔️  -   1    0 💤 ±0  0 ±0 
1 269 runs   - 5  1 233 ✔️  - 12  36 💤 +7  0 ±0 

Results for commit 7ac248b. ± Comparison against base commit 697eda7.

This pull request removes 1 test.
tests.unit.test_utilities ‑ test_groupby_unsorted

♻️ This comment has been updated with latest results.

Copy link
Contributor

@treff7es treff7es left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shirshanka shirshanka merged commit ea2b092 into datahub-project:master Feb 11, 2022
@hsheth2 hsheth2 deleted the groupby branch February 11, 2022 14:47
ne1r0n pushed a commit to ne1r0n/datahub that referenced this pull request Feb 13, 2022
hevandro-veiga pushed a commit to hevandro-veiga/datahub that referenced this pull request Feb 18, 2022
maggiehays pushed a commit to maggiehays/datahub that referenced this pull request Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants