Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docs): make intro to metadata ingestion easier for beginners #4039

Merged
merged 6 commits into from
Feb 11, 2022
Merged

fix(docs): make intro to metadata ingestion easier for beginners #4039

merged 6 commits into from
Feb 11, 2022

Conversation

anshbansal
Copy link
Collaborator

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@github-actions
Copy link

github-actions bot commented Feb 2, 2022 •
edited
Loading

Unit Test Results (build & test)

  69 files  +  1    69 suites  +1   11m 40s ⏱️ + 6m 10s
604 tests +69  545 ✔️ +62  59 💤 +7  0 ❌ ±0 

Results for commit 3843b9e. ± Comparison against base commit 4dba8fe.

♻️ This comment has been updated with latest results.

@anshbansal anshbansal changed the title fix(docs): fix sidebar titles for clarity fix(docs): make intro to metadata ingestion easier for beginners Feb 2, 2022
@github-actions
Copy link

github-actions bot commented Feb 2, 2022 •
edited
Loading

Unit Test Results (metadata ingestion)

    3 files      3 suites   37m 54s ⏱️
311 tests 310 ✔️   0 💤 1 ❌
893 runs  865 ✔️ 27 💤 1 ❌

For more details on these failures, see this check.

Results for commit 3843b9e.

♻️ This comment has been updated with latest results.

shirshanka
shirshanka approved these changes Feb 11, 2022
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shirshanka shirshanka merged commit 7fcc71e into datahub-project:master Feb 11, 2022
@anshbansal anshbansal deleted the fix_navigation_bar_titles branch February 11, 2022 17:06
ne1r0n pushed a commit to ne1r0n/datahub that referenced this pull request Feb 13, 2022
@anshbansal @ne1r0n
fix(docs): make intro to metadata ingestion easier for beginners (dat…
e4cdfa5 
…ahub-project#4039)

* fix(docs): fix sidebar titles for clarity

* re-arrange docs to make Intro to Metadata ingestion easier for beginners

* minor changes for readability

* add heading

* docs: add note for common question
hevandro-veiga pushed a commit to hevandro-veiga/datahub that referenced this pull request Feb 18, 2022
@anshbansal @hevandro-veiga
fix(docs): make intro to metadata ingestion easier for beginners (dat…
fcca51d 
…ahub-project#4039)

* fix(docs): fix sidebar titles for clarity

* re-arrange docs to make Intro to Metadata ingestion easier for beginners

* minor changes for readability

* add heading

* docs: add note for common question
maggiehays pushed a commit to maggiehays/datahub that referenced this pull request Aug 1, 2022
@anshbansal @maggiehays
fix(docs): make intro to metadata ingestion easier for beginners (dat…
adf2ae6 
…ahub-project#4039)

* fix(docs): fix sidebar titles for clarity

* re-arrange docs to make Intro to Metadata ingestion easier for beginners

* minor changes for readability

* add heading

* docs: add note for common question
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirshanka shirshanka shirshanka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anshbansal @shirshanka