Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ingest): log CLI invocations and completions #4062

Merged
merged 2 commits into from
Feb 5, 2022
Merged

feat(ingest): log CLI invocations and completions #4062

merged 2 commits into from
Feb 5, 2022

Conversation

kevinhu
Copy link
Contributor

@kevinhu kevinhu commented Feb 4, 2022 •
edited
Loading

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@github-actions
Copy link

github-actions bot commented Feb 4, 2022 •
edited
Loading

Unit Test Results (build & test)

  68 files  ±0    68 suites  ±0   10m 15s ⏱️ + 1m 53s
596 tests ±0  537 ✔️ ±0  59 💤 ±0  0 ❌ ±0 

Results for commit 5c4a095. ± Comparison against base commit c8922b3.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Feb 4, 2022 •
edited
Loading

Unit Test Results (metadata ingestion)

    3 files  ±0      3 suites  ±0   38m 54s ⏱️ + 1m 29s
301 tests ±0  301 ✔️ ±0    0 💤 ±0  0 ❌ ±0 
863 runs  ±0  843 ✔️ +7  20 💤  - 7  0 ❌ ±0 

Results for commit 5c4a095. ± Comparison against base commit c8922b3.

♻️ This comment has been updated with latest results.

shirshanka
shirshanka approved these changes Feb 5, 2022
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shirshanka shirshanka merged commit 6fe062f into datahub-project:master Feb 5, 2022
aditya-radhakrishnan pushed a commit to aditya-radhakrishnan/datahub that referenced this pull request Feb 7, 2022
@kevinhu
feat(ingest): log CLI invocations and completions (datahub-project#4062)
af65ea3
ne1r0n pushed a commit to ne1r0n/datahub that referenced this pull request Feb 13, 2022
@kevinhu @ne1r0n
feat(ingest): log CLI invocations and completions (datahub-project#4062)
679c22b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirshanka shirshanka shirshanka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevinhu @shirshanka