-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/users and groups UI updated as per new design #4134
Merged
shirshanka
merged 20 commits into
datahub-project:master
from
ShubhamThakre:feature/users-and-groups-ui-updates
Feb 17, 2022
Merged
Feature/users and groups UI updated as per new design #4134
shirshanka
merged 20 commits into
datahub-project:master
from
ShubhamThakre:feature/users-and-groups-ui-updates
Feb 17, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…added | editProfile update query mutation pending
…an up for UserProfile and UserAssets file
…l to user sidebar section
…tions added with"NA"
gabe-lyons
reviewed
Feb 14, 2022
gabe-lyons
reviewed
Feb 14, 2022
gabe-lyons
reviewed
Feb 14, 2022
gabe-lyons
reviewed
Feb 14, 2022
gabe-lyons
reviewed
Feb 14, 2022
gabe-lyons
reviewed
Feb 14, 2022
gabe-lyons
reviewed
Feb 14, 2022
gabe-lyons
reviewed
Feb 14, 2022
gabe-lyons
reviewed
Feb 14, 2022
gabe-lyons
reviewed
Feb 14, 2022
jjoyce0510
reviewed
Feb 15, 2022
jjoyce0510
reviewed
Feb 15, 2022
jjoyce0510
reviewed
Feb 15, 2022
jjoyce0510
reviewed
Feb 15, 2022
jjoyce0510
reviewed
Feb 15, 2022
jjoyce0510
reviewed
Feb 15, 2022
jjoyce0510
reviewed
Feb 15, 2022
jjoyce0510
reviewed
Feb 15, 2022
jjoyce0510
reviewed
Feb 15, 2022
jjoyce0510
reviewed
Feb 15, 2022
jjoyce0510
reviewed
Feb 15, 2022
jjoyce0510
reviewed
Feb 15, 2022
jjoyce0510
reviewed
Feb 15, 2022
jjoyce0510
reviewed
Feb 15, 2022
jjoyce0510
reviewed
Feb 15, 2022
jjoyce0510
reviewed
Feb 15, 2022
jjoyce0510
reviewed
Feb 15, 2022
jjoyce0510
reviewed
Feb 15, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall is looking really good. Some comments before we merge it in.
Shubham - linting is failing in CI. With these failures: 1:84 error Insert `·` prettier/prettier
4:53 error Insert `;` prettier/prettier
7:10 error Delete `·` prettier/prettier
8:27 error Insert `;` prettier/prettier
✖ 4 problems (4 errors, 0 warnings)
4 errors and 0 warnings potentially fixable with the `--fix` option.```
You can run `yarn run lint` locally to triage and fix the issues before raising the PR |
jjoyce0510
reviewed
Feb 16, 2022
jjoyce0510
reviewed
Feb 17, 2022
jjoyce0510
reviewed
Feb 17, 2022
jjoyce0510
reviewed
Feb 17, 2022
jjoyce0510
reviewed
Feb 17, 2022
jjoyce0510
reviewed
Feb 17, 2022
shirshanka
approved these changes
Feb 17, 2022
hevandro-veiga
pushed a commit
to hevandro-veiga/datahub
that referenced
this pull request
Feb 18, 2022
maggiehays
pushed a commit
to maggiehays/datahub
that referenced
this pull request
Aug 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features Updates:
User and groups UI modified as per new design- LINK
The screen shot are attached below:
@jjoyce0510 @gabe-lyons