Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/users and groups UI updated as per new design #4134

Conversation

ShubhamThakre
Copy link
Contributor

@ShubhamThakre ShubhamThakre commented Feb 14, 2022

Features Updates:

  • User and groups UI modified as per new design- LINK

    • User side bar section added
    • Assets tab section added
    • Groups tab section added
    • Edit Profile Modal popup added:
      • Validation added on the fields
      • Mutation query updated to update the fields
  • The screen shot are attached below:

Screen Shot 2022-02-14 at 9 47 34 PM

Screen Shot 2022-02-14 at 9 48 56 PM

Screen Shot 2022-02-14 at 9 47 14 PM

@jjoyce0510 @gabe-lyons

@github-actions
Copy link

github-actions bot commented Feb 14, 2022

Unit Test Results (build & test)

  70 files  ±0    70 suites  ±0   10m 35s ⏱️ - 2m 20s
609 tests ±0  550 ✔️ ±0  59 💤 ±0  0 ±0 

Results for commit 08e6527. ± Comparison against base commit 06bb033.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@jjoyce0510 jjoyce0510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall is looking really good. Some comments before we merge it in.

datahub-web-react/src/app/entity/user/UserProfile.tsx Outdated Show resolved Hide resolved
datahub-web-react/src/app/entity/user/UserProfile.tsx Outdated Show resolved Hide resolved
datahub-web-react/src/app/entity/user/UserProfile.tsx Outdated Show resolved Hide resolved
datahub-web-react/src/app/entity/user/UserProfile.tsx Outdated Show resolved Hide resolved
datahub-web-react/src/app/entity/user/UserProfile.tsx Outdated Show resolved Hide resolved
datahub-web-react/src/app/entity/user/UserProfile.tsx Outdated Show resolved Hide resolved
datahub-web-react/src/app/entity/user/type.ts Show resolved Hide resolved
datahub-web-react/src/app/shared/RoutedTabs.tsx Outdated Show resolved Hide resolved
datahub-web-react/src/graphql/user.graphql Show resolved Hide resolved
@jjoyce0510
Copy link
Collaborator

Shubham - linting is failing in CI. With these failures:

  1:84  error  Insert `·`  prettier/prettier
  4:53  error  Insert `;`  prettier/prettier
  7:10  error  Delete `·`  prettier/prettier
  8:27  error  Insert `;`  prettier/prettier

 4 problems (4 errors, 0 warnings)
  4 errors and 0 warnings potentially fixable with the `--fix` option.```

You can run `yarn run lint` locally to triage and fix the issues before raising the PR

@shirshanka shirshanka merged commit 413990d into datahub-project:master Feb 17, 2022
hevandro-veiga pushed a commit to hevandro-veiga/datahub that referenced this pull request Feb 18, 2022
maggiehays pushed a commit to maggiehays/datahub that referenced this pull request Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants