-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ingestion): add java protobuf schema ingestion #4178
feat(ingestion): add java protobuf schema ingestion #4178
Conversation
12c82a2
to
a88bb7b
Compare
b3189c0
to
e2e8a97
Compare
Sync with upstream
e2e8a97
to
4e80ed5
Compare
I'm working on adding protobuf support to the kafka source and I wanted to compare the output of this module and my changes. I noticed that the README.md is partially incorrect; the first code example throws a NullPointerException unless you add a |
7cbcdc6
to
3bed41d
Compare
From upstream
37c1790
to
f2de1d9
Compare
Upstream sync
07c64df
to
5d503c2
Compare
Upstream
Adding additional submodule to allow ingestion of compiled protobuf binaries.
5d503c2
to
3b38bfb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…4178) Co-authored-by: leifker <[email protected]>
Adding additional submodule to allow mpiled protobuf binaries.
The java11 compatibility adjustments are broken out into this PR.
Checklist