Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ingestion): add java protobuf schema ingestion #4178

Merged
merged 5 commits into from
Mar 11, 2022

Conversation

leifker
Copy link
Contributor

@leifker leifker commented Feb 18, 2022

Adding additional submodule to allow mpiled protobuf binaries.

The java11 compatibility adjustments are broken out into this PR.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@leifker leifker force-pushed the protobuf-ingestion branch 9 times, most recently from 12c82a2 to a88bb7b Compare February 24, 2022 19:31
@github-actions
Copy link

github-actions bot commented Feb 25, 2022

Unit Test Results (build & test)

  91 files  +16    91 suites  +16   7m 32s ⏱️ +3s
595 tests +43  543 ✔️ +43  52 💤 ±0  0 ±0 

Results for commit 3b38bfb. ± Comparison against base commit fab9c23.

♻️ This comment has been updated with latest results.

@leifker leifker force-pushed the protobuf-ingestion branch from b3189c0 to e2e8a97 Compare March 2, 2022 13:51
@leifker leifker force-pushed the protobuf-ingestion branch from e2e8a97 to 4e80ed5 Compare March 2, 2022 15:28
@luisvicentesanchez
Copy link
Contributor

luisvicentesanchez commented Mar 4, 2022

I'm working on adding protobuf support to the kafka source and I wanted to compare the output of this module and my changes. I noticed that the README.md is partially incorrect; the first code example throws a NullPointerException unless you add a setSchema("") to the ProtobugDataset creation.

@leifker leifker force-pushed the protobuf-ingestion branch 3 times, most recently from 7cbcdc6 to 3bed41d Compare March 8, 2022 12:52
@leifker leifker force-pushed the protobuf-ingestion branch 2 times, most recently from 37c1790 to f2de1d9 Compare March 9, 2022 15:22
@leifker leifker force-pushed the protobuf-ingestion branch 3 times, most recently from 07c64df to 5d503c2 Compare March 10, 2022 21:12
leifker and others added 2 commits March 11, 2022 08:21
Adding additional submodule to allow ingestion of compiled protobuf binaries.
@leifker leifker force-pushed the protobuf-ingestion branch from 5d503c2 to 3b38bfb Compare March 11, 2022 14:23
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shirshanka shirshanka merged commit bb8f45b into datahub-project:master Mar 11, 2022
maggiehays pushed a commit to maggiehays/datahub that referenced this pull request Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants