fix(ui): Return empty search response on invalid characters in search #4193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shirshanka
approved these changes
Feb 18, 2022
aditya-radhakrishnan
pushed a commit
to aditya-radhakrishnan/datahub
that referenced
this pull request
Feb 18, 2022
aditya-radhakrishnan
pushed a commit
to aditya-radhakrishnan/datahub
that referenced
this pull request
Feb 18, 2022
maggiehays
pushed a commit
to maggiehays/datahub
that referenced
this pull request
Aug 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we use reserved characters to query elastic, the DataHub API will throw 500s. We want to catch and suppress such exceptions, abstracting them away from our callers.
Screenshot below showing exception has been handled on server:
Checklist