Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(notebook): add data models for Notebook entity #4223

Merged
merged 6 commits into from
Mar 21, 2022
Merged

feat(notebook): add data models for Notebook entity #4223

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e965b13
add Notebook data model
Mar 15, 2022
8e70193
resolve PR comments
Mar 16, 2022
a3dc84f
add dataPlatformInstance aspect and make notebookTool non-searchable
Mar 17, 2022
f49773a
make data doc cell title optional
Mar 17, 2022
97f5b67
mark Notebook related aspects and entity as in BETA version
Mar 21, 2022
100b9ae
add comments in entry-registry.yml for notebook entity
Mar 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions metadata-models/src/main/pegasus/com/linkedin/notebook/EditableNotebookProperties.pdl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import com.linkedin.common.ChangeAuditStamps
/**
* Stores editable changes made to properties. This separates changes made from
* ingestion pipelines and edits in the UI to avoid accidental overwrites of user-provided data by ingestion pipelines
* Note: This is IN BETA version
*/
@Aspect = {
"name": "editableNotebookProperties"
Expand Down
1 change: 1 addition & 0 deletions metadata-models/src/main/pegasus/com/linkedin/notebook/NotebookContent.pdl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ namespace com.linkedin.notebook

/**
* Content in a Notebook
* Note: This is IN BETA version
*/
@Aspect = {
"name": "notebookContent"
Expand Down
1 change: 1 addition & 0 deletions metadata-models/src/main/pegasus/com/linkedin/notebook/NotebookInfo.pdl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import com.linkedin.common.ExternalReference

/**
* Information about a Notebook
* Note: This is IN BETA version
*/
@Aspect = {
"name": "notebookInfo"
Expand Down
1 change: 1 addition & 0 deletions metadata-models/src/main/resources/entity-registry.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ entities:
- domains
- container
- deprecation
# Note: This is in BETA version
tc350981 marked this conversation as resolved.
Show resolved Hide resolved
- name: notebook
keyAspect: notebookKey
aspects:
Expand Down