Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ingest) kafka-connect: Pass the env variable as part of making dataset #4244

Merged

Conversation

arunvasudevan
Copy link
Collaborator

Checklist

Datasets created as part of kafka connect ingestion are created with default PROD env. This fix is to pass the env variable from the recipe.

@github-actions
Copy link

github-actions bot commented Feb 24, 2022

Unit Test Results (metadata ingestion)

       5 files         5 suites   46m 41s ⏱️
   332 tests    332 ✔️   0 💤 0
1 507 runs  1 469 ✔️ 38 💤 0

Results for commit 616f342.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Feb 24, 2022

Unit Test Results (build & test)

  70 files  ±0    70 suites  ±0   10m 22s ⏱️ - 2m 6s
611 tests ±0  552 ✔️ ±0  59 💤 ±0  0 ±0 

Results for commit 616f342. ± Comparison against base commit 975b356.

♻️ This comment has been updated with latest results.

@arunvasudevan arunvasudevan force-pushed the fix_env_kafka_connect_lineage branch from a5f232f to 616f342 Compare February 24, 2022 20:57
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shirshanka shirshanka merged commit a394096 into datahub-project:master Feb 24, 2022
@arunvasudevan arunvasudevan deleted the fix_env_kafka_connect_lineage branch March 4, 2022 19:30
maggiehays pushed a commit to maggiehays/datahub that referenced this pull request Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants