Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(mae-comsumer): wrong aspect name in usage event transformer #4249

Merged
merged 1 commit into from
Feb 25, 2022
Merged

fix(mae-comsumer): wrong aspect name in usage event transformer #4249

merged 1 commit into from
Feb 25, 2022

Conversation

zhoxie-cisco
Copy link
Contributor

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

dexter-mh-lee
dexter-mh-lee approved these changes Feb 25, 2022
View reviewed changes
Copy link
Contributor

@dexter-mh-lee dexter-mh-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. Can't believe this has been there since the beginning.

shirshanka
shirshanka approved these changes Feb 25, 2022
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions
Copy link

Unit Test Results (build & test)

  70 files  ±0    70 suites  ±0   13m 3s ⏱️ + 1m 11s
611 tests ±0  552 ✔️ +1  59 💤 ±0  0 ❌  - 1 

Results for commit 242ff1f. ± Comparison against base commit 6ff551c.

@shirshanka shirshanka merged commit 0146d47 into datahub-project:master Feb 25, 2022
@zhoxie-cisco zhoxie-cisco deleted the linkedin20220225 branch February 25, 2022 05:13
maggiehays pushed a commit to maggiehays/datahub that referenced this pull request Aug 1, 2022
@zhoxie-cisco @zhoxie @maggiehays
fix(mae-consumer): usage event transformer was using wrong aspect nam…
d6375f6 
…e. (datahub-project#4249)

Co-authored-by: zhoxie-cisco <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirshanka shirshanka shirshanka approved these changes

@dexter-mh-lee dexter-mh-lee dexter-mh-lee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zhoxie-cisco @dexter-mh-lee @shirshanka @zhoxie