Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(timeline): fix smoke test #4285

Merged
merged 1 commit into from
Mar 2, 2022
Merged

test(timeline): fix smoke test #4285

merged 1 commit into from
Mar 2, 2022

Conversation

RyanHolstien
Copy link
Collaborator

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

rslanka
rslanka approved these changes Mar 1, 2022
View reviewed changes
Copy link
Contributor

@rslanka rslanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions
Copy link

github-actions bot commented Mar 1, 2022

Unit Test Results (build & test)

  71 files  ±0    71 suites  ±0   13m 7s ⏱️ - 1m 45s
618 tests ±0  559 ✔️ +1  59 💤 ±0  0 ❌  - 1 

Results for commit 5b7e1bd. ± Comparison against base commit e2f8db7.

shirshanka
shirshanka approved these changes Mar 2, 2022
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shirshanka shirshanka merged commit d8368e9 into datahub-project:master Mar 2, 2022
maggiehays pushed a commit to maggiehays/datahub that referenced this pull request Aug 1, 2022
@RyanHolstien @maggiehays
fix(ci): timeline - fix assertion in test (datahub-project#4285)
324a8d9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rslanka rslanka rslanka approved these changes

@shirshanka shirshanka shirshanka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RyanHolstien @shirshanka @rslanka