Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: revert changes to OpenApi casing #4291

Merged
merged 1 commit into from
Mar 4, 2022
Merged

fix: revert changes to OpenApi casing #4291

merged 1 commit into from
Mar 4, 2022

Conversation

anshbansal
Copy link
Collaborator

@anshbansal anshbansal commented Mar 2, 2022 •
edited
Loading

Revert of casing change #4086 of platform

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@github-actions
Copy link

github-actions bot commented Mar 2, 2022 •
edited
Loading

Unit Test Results (metadata ingestion)

       5 files  ±0         5 suites  ±0   44m 10s ⏱️ -21s
   343 tests ±0     343 ✔️ ±0    0 💤 ±0  0 ❌ ±0 
1 562 runs  ±0  1 531 ✔️ +7  31 💤  - 7  0 ❌ ±0 

Results for commit 4bd85ef. ± Comparison against base commit 2a5cf3d.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Mar 2, 2022 •
edited
Loading

Unit Test Results (build & test)

  71 files  ±0    71 suites  ±0   14m 19s ⏱️ + 1m 8s
618 tests ±0  559 ✔️ ±0  59 💤 ±0  0 ❌ ±0 

Results for commit 4bd85ef. ± Comparison against base commit 2a5cf3d.

♻️ This comment has been updated with latest results.

@anshbansal anshbansal closed this Mar 2, 2022
@anshbansal anshbansal reopened this Mar 2, 2022
@anshbansal anshbansal closed this Mar 3, 2022
@anshbansal anshbansal reopened this Mar 3, 2022
@shirshanka
Copy link
Contributor

@vlavorini : FYI -> we are making this change since we don't want to break existing pipelines that were already using the camel-cased version of the platform.

shirshanka
shirshanka approved these changes Mar 3, 2022
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shirshanka shirshanka merged commit 9a9a5c3 into datahub-project:master Mar 4, 2022
@anshbansal anshbansal deleted the fix_breaking_change_pr_4086 branch March 7, 2022 08:14
maggiehays pushed a commit to maggiehays/datahub that referenced this pull request Aug 1, 2022
@anshbansal @maggiehays
fix: revert changes to OpenApi casing (datahub-project#4291)
903b106
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirshanka shirshanka shirshanka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anshbansal @shirshanka