Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ingest): mysql- add database_alias functionality #4319

Merged
merged 6 commits into from
Mar 9, 2022

Conversation

vcs9
Copy link
Contributor

@vcs9 vcs9 commented Mar 4, 2022

This PR is to add functionality for database_alias in MySQL.

For a table called test_db_001.test_table, adding a database_alias of test_db would rename the table as test_db.test_table

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@github-actions
Copy link

github-actions bot commented Mar 4, 2022

Unit Test Results (build & test)

  76 files  ±0    76 suites  ±0   26m 48s ⏱️ + 11m 7s
629 tests  - 1  569 ✔️  - 2  59 💤 ±0  1 +1 

For more details on these failures, see this check.

Results for commit b8708c7. ± Comparison against base commit 9029292.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Mar 4, 2022

Unit Test Results (metadata ingestion)

       5 files         5 suites   45m 4s ⏱️
   360 tests    360 ✔️   0 💤 0
1 638 runs  1 607 ✔️ 31 💤 0

Results for commit b8708c7.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shirshanka shirshanka merged commit 733413f into datahub-project:master Mar 9, 2022
maggiehays pushed a commit to maggiehays/datahub that referenced this pull request Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants