Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): Supporting unknown data platform type #4361

Merged

Conversation

jjoyce0510
Copy link
Collaborator

@jjoyce0510 jjoyce0510 commented Mar 9, 2022

Summary
Supporting a fallback data platform urn in the case that one cannot be associated with an asset. This is to support the new concept of "data platform instances" which are manifested as individual aspects. Also fixing a bug with containers which will allow the unknown platform type to be returned if one cannot be resolved.

Also adding some default containers to bootstrap_mce.json.

Status
Ready for review.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@jjoyce0510 jjoyce0510 changed the title feat(ui): Supporting unknown data platform type fix(ui): Supporting unknown data platform type Mar 9, 2022
@github-actions
Copy link

github-actions bot commented Mar 9, 2022

Unit Test Results (build & test)

  76 files  ±0    76 suites  ±0   16m 9s ⏱️ - 1m 38s
629 tests ±0  570 ✔️ ±0  59 💤 ±0  0 ±0 

Results for commit 9717b3a. ± Comparison against base commit 733413f.

@github-actions
Copy link

github-actions bot commented Mar 9, 2022

Unit Test Results (metadata ingestion)

       5 files  ±0         5 suites  ±0   50m 9s ⏱️ + 2m 8s
   360 tests ±0     360 ✔️ ±0    0 💤 ±0  0 ±0 
1 638 runs  ±0  1 607 ✔️ +7  31 💤  - 7  0 ±0 

Results for commit 9717b3a. ± Comparison against base commit 733413f.

@shirshanka shirshanka merged commit 870407b into datahub-project:master Mar 10, 2022
maggiehays pushed a commit to maggiehays/datahub that referenced this pull request Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants