Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adding gradle, pip cache via gh cache, docker cache via dockerhub #4387

Merged
merged 18 commits into from
Apr 8, 2022
Merged

feat: adding gradle, pip cache via gh cache, docker cache via dockerhub #4387

merged 18 commits into from
Apr 8, 2022

Conversation

anshbansal
Copy link
Collaborator

@anshbansal anshbansal commented Mar 11, 2022 •
edited
Loading

Docker cache tested by

The docker cache is not fully being used most probably because we have not ignored the .git folder for showing the version number

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@github-actions
Copy link

github-actions bot commented Mar 11, 2022 •
edited
Loading

Unit Test Results (build & test)

  96 files    96 suites   27m 40s ⏱️
687 tests 628 ✔️ 59 💤 0 ❌

Results for commit 6d57389.

♻️ This comment has been updated with latest results.

@anshbansal anshbansal changed the title feat: adding gradle, pip cache, docker cache for feat: adding gradle, pip cache via gh cache, docker cache via dockerhub Mar 11, 2022
@anshbansal anshbansal marked this pull request as ready for review March 11, 2022 15:31
dexter-mh-lee
dexter-mh-lee approved these changes Mar 17, 2022
View reviewed changes
Copy link
Contributor

@dexter-mh-lee dexter-mh-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dexter-mh-lee
Copy link
Contributor

@anshbansal Seems like build is failing. Changes look great overall!

@anshbansal anshbansal closed this Mar 17, 2022
@anshbansal anshbansal reopened this Mar 17, 2022
@anshbansal anshbansal closed this Mar 17, 2022
@anshbansal anshbansal reopened this Mar 17, 2022
@anshbansal anshbansal closed this Mar 24, 2022
@anshbansal anshbansal reopened this Mar 24, 2022
@anshbansal anshbansal closed this Apr 6, 2022
@anshbansal anshbansal reopened this Apr 6, 2022
@anshbansal anshbansal closed this Apr 7, 2022
@anshbansal anshbansal reopened this Apr 7, 2022
@dexter-mh-lee dexter-mh-lee merged commit b6de051 into datahub-project:master Apr 8, 2022
@anshbansal anshbansal deleted the attempt-cache-3 branch April 8, 2022 16:25
dexter-mh-lee pushed a commit that referenced this pull request Apr 11, 2022
Revert "feat: adding gradle, pip cache via gh cache, docker cache via…
34e8883 
… dockerhub (#4387)"

This reverts commit b6de051.
@dexter-mh-lee dexter-mh-lee mentioned this pull request Apr 11, 2022
Merged
dexter-mh-lee pushed a commit that referenced this pull request Apr 11, 2022
Revert "feat: adding gradle, pip cache via gh cache, docker cache via…
2a8ae27 
… dockerhub (#4387)" (#4637)

This reverts commit b6de051.
maggiehays pushed a commit to maggiehays/datahub that referenced this pull request Aug 1, 2022
@anshbansal @maggiehays
feat: adding gradle, pip cache via gh cache, docker cache via dockerh…
18fcc02 
…ub (datahub-project#4387)

* attempt cache

* change cache keys

* use docker repository for caching

* change buildcache tag

* change tag

* fix cache key

* take docker cache from head buildcache

* try not pushing when not publishing

* change to use templating

* change docker caching

* test change org name

* check using cache

* revert changes

* remove gradle cache from build and test workflow
maggiehays pushed a commit to maggiehays/datahub that referenced this pull request Aug 1, 2022
@maggiehays
Revert "feat: adding gradle, pip cache via gh cache, docker cache via…
0bcb33c 
… dockerhub (datahub-project#4387)" (datahub-project#4637)

This reverts commit b6de051.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dexter-mh-lee dexter-mh-lee dexter-mh-lee approved these changes

Assignees

@dexter-mh-lee dexter-mh-lee

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anshbansal @dexter-mh-lee