build(markupsafe): update markupsafe pinning for Airflow compatibility #4388
Conversation
| @@ -51,7 +51,8 @@ def get_long_description(): | |||
| # Markupsafe breaking change broke Jinja and some other libs | |||
| # Pinning it to a version which works even though we are not using explicitly | |||
There was a problem hiding this comment.
probably worth removing these comments, but I thought I'd get some feedback on this change first.
There was a problem hiding this comment.
Doesn't the new constraint allow for versions newer than 2.0.1 ? The original comment here seems to indicate that versions newer than 2.0.1 will break Jinja and other libs.
There was a problem hiding this comment.
Yea, let me go ahead and just pin it to 2.0.1; The reason I swapped it to what Airflow uses is because I believe the markupsafe breaking change issue is resolved on 2.0.1 and has been pushed off to 2.1.0, based on pallets/markupsafe#286 and pallets/markupsafe#283. Either way, I'll keep it pinned at 2.0.1. Thanks!
|
The failures on this PR don't seem related to the change, as some other pull requests are failing for the same reasons. Could someone provide assistance on this? |
Airflow 2.0.2 - 2.2.2 has a pin on markupsafe as >=1.1.1,<2.0 because of a bug shipped in markupsafe 2.0.x, preventing the ability to integrate datahub and airflow. This patch changes the pinnings to match Airflow.
Airflow 2.0.2 - 2.2.2 has a pin on markupsafe as >=1.1.1,<2.0 because
of a bug shipped in markupsafe 2.0.x, preventing the ability to
integrate datahub and airflow.
This patch changes the pinnings to match Airflow.
Checklist