Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lineage): hide soft deleted nodes in lineage & adds banner in entity page #4410

Merged

Conversation

gabe-lyons
Copy link
Contributor

@gabe-lyons gabe-lyons commented Mar 14, 2022

image

viz with upstream entity hidden:
image

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@github-actions
Copy link

github-actions bot commented Mar 15, 2022

Unit Test Results (build & test)

  92 files  ±0    92 suites  ±0   15m 6s ⏱️ - 2m 2s
672 tests ±0  613 ✔️ +1  59 💤 ±0  0  - 1 

Results for commit 6b0fc2d. ± Comparison against base commit a12c9d2.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@dexter-mh-lee dexter-mh-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shirshanka shirshanka merged commit 540d1b3 into datahub-project:master Mar 15, 2022
maggiehays pushed a commit to maggiehays/datahub that referenced this pull request Aug 1, 2022
…tity page (datahub-project#4410)

* query for custom properties on containers

* updating queries

* hide soft deleted entities in lineage viz

* add banner for soft deleted entities

* fix tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants