fix(oidc): Fixing OIDC encryption bug in v0.8.29 #4418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dexter-mh-lee
approved these changes
Mar 16, 2022
Closed
maggiehays
pushed a commit
to maggiehays/datahub
that referenced
this pull request
Aug 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a recently released issue in version v0.8.29, where the encryption key used to sign session cookies for Pac4j (OIDC only) could be of invalid length depending on what value of DATAHUB_SECRET was used. This was due to a misalignment in the required number of bytes for an AES key (16 or 32) and the number of bytes we were resolving as this key. This PR fixes this.
Validation
Reproduced issue and tested the fix locally using Okta. Changed value of DATAHUB_SECRET to many things to confirm.
Checklist