Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't set None default #4422

Merged
merged 2 commits into from
Mar 16, 2022
Merged

fix: don't set None default #4422

merged 2 commits into from
Mar 16, 2022

Conversation

anshbansal
Copy link
Collaborator

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@github-actions
Copy link

github-actions bot commented Mar 16, 2022 •
edited
Loading

Unit Test Results (build & test)

  92 files  ±0    92 suites  ±0   15m 57s ⏱️ -12s
673 tests ±0  614 ✔️ ±0  59 💤 ±0  0 ❌ ±0 

Results for commit 751794c. ± Comparison against base commit 2d10d99.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Mar 16, 2022 •
edited
Loading

Unit Test Results (metadata ingestion)

       5 files  ±0         5 suites  ±0   44m 54s ⏱️ - 4m 6s
   362 tests ±0     362 ✔️ ±0    0 💤 ±0  0 ❌ ±0 
1 657 runs  ±0  1 619 ✔️ ±0  38 💤 ±0  0 ❌ ±0 

Results for commit 751794c. ± Comparison against base commit 2d10d99.

♻️ This comment has been updated with latest results.

@anshbansal
Copy link
Collaborator Author

@gabe-lyons How do we regenerate all the golden files?

@anshbansal anshbansal closed this Mar 16, 2022
@anshbansal anshbansal reopened this Mar 16, 2022
@jjoyce0510 jjoyce0510 merged commit d4d1635 into datahub-project:master Mar 16, 2022
@anshbansal anshbansal deleted the fix-default-description branch March 17, 2022 06:20
maggiehays pushed a commit to maggiehays/datahub that referenced this pull request Aug 1, 2022
@anshbansal @maggiehays
fix: don't set None default (datahub-project#4422)
47795fa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjoyce0510 jjoyce0510 jjoyce0510 approved these changes

@gabe-lyons gabe-lyons gabe-lyons approved these changes

Assignees

@gabe-lyons gabe-lyons

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anshbansal @gabe-lyons @jjoyce0510