Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingest): make tableau ingestion more resilient to error #4494

Merged
merged 10 commits into from
Mar 30, 2022
Merged

fix(ingest): make tableau ingestion more resilient to error #4494

merged 10 commits into from
Mar 30, 2022

Conversation

cuong-pham
Copy link
Contributor

@cuong-pham cuong-pham commented Mar 24, 2022 •
edited
Loading

  • Null check for data field in the query result
  • Make the pipeline run keep running when mce_extract raise Exception

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@github-actions
Copy link

github-actions bot commented Mar 25, 2022 •
edited
Loading

Unit Test Results (build & test)

  92 files  ±0    92 suites  ±0   12m 13s ⏱️ - 4m 53s
674 tests ±0  615 ✔️ ±0  59 💤 ±0  0 ❌ ±0 

Results for commit 50d02ab. ± Comparison against base commit ab36ac0f.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Mar 25, 2022 •
edited
Loading

Unit Test Results (metadata ingestion)

       5 files  ±0         5 suites  ±0   44m 39s ⏱️ - 9m 16s
   371 tests ±0     371 ✔️ ±0    0 💤 ±0  0 ❌ ±0 
1 702 runs  ±0  1 671 ✔️ ±0  31 💤 ±0  0 ❌ ±0 

Results for commit 50d02ab. ± Comparison against base commit ab36ac0f.

♻️ This comment has been updated with latest results.

@jjoyce0510 jjoyce0510 merged commit 4833452 into datahub-project:master Mar 30, 2022
maggiehays pushed a commit to maggiehays/datahub that referenced this pull request Aug 1, 2022
@cuong-pham @maggiehays
fix(ingest): make tableau ingestion more resilient to error (datahub-…
e6238b7 
…project#4494)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mayurinehate mayurinehate mayurinehate approved these changes

@jjoyce0510 jjoyce0510 jjoyce0510 approved these changes

Assignees

@jjoyce0510 jjoyce0510

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cuong-pham @jjoyce0510 @mayurinehate