Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ingest): dbt,looker,sql_common,kafka - moving sources to produce… #4496

Merged
merged 1 commit into from
Mar 27, 2022
Merged

feat(ingest): dbt,looker,sql_common,kafka - moving sources to produce… #4496

merged 1 commit into from
Mar 27, 2022

Conversation

shirshanka
Copy link
Contributor

… display names and subtypes more consistently

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@shirshanka
feat(ingest): dbt,looker,sql_common,kafka - moving sources to produce…
4f87a1e 
… display names and subtypes more consistently
@github-actions
Copy link

Unit Test Results (build & test)

  92 files  +  1    92 suites  +1   15m 4s ⏱️ + 8m 22s
674 tests +77  615 ✔️ +70  59 💤 +7  0 ❌ ±0 

Results for commit 4f87a1e. ± Comparison against base commit c9b40ec.

@github-actions
Copy link

Unit Test Results (metadata ingestion)

       5 files         5 suites   48m 24s ⏱️
   371 tests    371 ✔️   0 💤 0 ❌
1 702 runs  1 671 ✔️ 31 💤 0 ❌

Results for commit 4f87a1e.

@shirshanka shirshanka requested a review from treff7es March 25, 2022 05:39
treff7es
treff7es approved these changes Mar 25, 2022
View reviewed changes
Copy link
Contributor

@treff7es treff7es left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

metadata-ingestion/src/datahub/ingestion/source/kafka.py Show resolved Hide resolved
@shirshanka shirshanka merged commit a69eac8 into datahub-project:master Mar 27, 2022
@anshbansal anshbansal mentioned this pull request Apr 13, 2022
Merged
5 tasks
maggiehays pushed a commit to maggiehays/datahub that referenced this pull request Aug 1, 2022
@shirshanka @maggiehays
feat(ingest): dbt,looker,sql_common,kafka - moving sources to produce…
5854490 
… display names and subtypes more consistently (datahub-project#4496)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@treff7es treff7es treff7es approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shirshanka @treff7es