Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(snowflake): allow/deny patterns #4504

Merged
merged 3 commits into from
Mar 28, 2022
Merged

fix(snowflake): allow/deny patterns #4504

merged 3 commits into from
Mar 28, 2022

Conversation

anshbansal
Copy link
Collaborator

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

treff7es
treff7es approved these changes Mar 28, 2022
View reviewed changes
Copy link
Contributor

@treff7es treff7es left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-actions
Copy link

Unit Test Results (metadata ingestion)

       5 files  ±0         5 suites  ±0   43m 57s ⏱️ - 3m 13s
   371 tests ±0     371 ✔️ ±0    0 💤 ±0  0 ❌ ±0 
1 702 runs  ±0  1 671 ✔️ ±0  31 💤 ±0  0 ❌ ±0 

Results for commit 327eaab. ± Comparison against base commit a69eac8.

@github-actions
Copy link

Unit Test Results (build & test)

  92 files  ±0    92 suites  ±0   17m 4s ⏱️ - 4m 15s
674 tests ±0  615 ✔️ ±0  59 💤 ±0  0 ❌ ±0 

Results for commit 327eaab. ± Comparison against base commit a69eac8.

@treff7es treff7es merged commit a702265 into datahub-project:master Mar 28, 2022
@anshbansal anshbansal deleted the fix-snowflake-patterns branch March 28, 2022 10:48
maggiehays pushed a commit to maggiehays/datahub that referenced this pull request Aug 1, 2022
@anshbansal @maggiehays
fix(snowflake): allow/deny patterns (datahub-project#4504)
0ebeb9f 
* fix(snowflake): allow/deny patterns

* fix lint failures

* fix linting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@treff7es treff7es treff7es approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anshbansal @treff7es