Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ingest): enable connection string for all sqlalchemy datasources #4508

Merged
merged 5 commits into from
Apr 8, 2022
Merged

feat(ingest): enable connection string for all sqlalchemy datasources #4508

merged 5 commits into from
Apr 8, 2022

Conversation

ms32035
Copy link
Contributor

@ms32035 ms32035 commented Mar 28, 2022

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@maggiehays maggiehays assigned treff7es and hsheth2 and unassigned treff7es Mar 28, 2022
@github-actions
Copy link

github-actions bot commented Mar 29, 2022 •
edited
Loading

Unit Test Results (metadata ingestion)

       5 files  ±    0         5 suites  ±0   59m 0s ⏱️ + 11m 32s
   392 tests +  21     392 ✔️ +  21    0 💤 ±0  0 ❌ ±0 
1 804 runs  +102  1 773 ✔️ +109  31 💤  - 7  0 ❌ ±0 

Results for commit f267f6c. ± Comparison against base commit 6b04dff.

This pull request removes 3 and adds 24 tests. Note that renamed tests count towards both. 
tests.unit.test_glue_source ‑ test_glue_ingest
tests.unit.test_glue_source ‑ test_underlying_platform_cannot_be_other_than_athena
tests.unit.test_kafka_source.KafkaSourceTest ‑ test_get_schema_str_replace_confluent_ref_avro

tests.integration.dbt.test_dbt ‑ test_dbt_stateful
tests.integration.s3.test_s3 ‑ test_data_lake_incorrect_config_raises_error
tests.integration.s3.test_s3 ‑ test_data_lake_local_ingest[folder_no_partition.json]
tests.integration.s3.test_s3 ‑ test_data_lake_local_ingest[folder_no_partition_exclude.json]
tests.integration.s3.test_s3 ‑ test_data_lake_local_ingest[folder_no_partition_filename.json]
tests.integration.s3.test_s3 ‑ test_data_lake_local_ingest[folder_no_partition_glob.json]
tests.integration.s3.test_s3 ‑ test_data_lake_local_ingest[folder_partition_basic.json]
tests.integration.s3.test_s3 ‑ test_data_lake_local_ingest[folder_partition_keyval.json]
tests.integration.s3.test_s3 ‑ test_data_lake_local_ingest[multiple_files.json]
tests.integration.s3.test_s3 ‑ test_data_lake_local_ingest[single_file.json]
…

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Mar 29, 2022 •
edited
Loading

Unit Test Results (build & test)

  96 files    96 suites   16m 11s ⏱️
686 tests 627 ✔️ 59 💤 0 ❌

Results for commit f267f6c.

♻️ This comment has been updated with latest results.

@hsheth2
Copy link
Collaborator

hsheth2 commented Apr 5, 2022

@jjoyce0510 let's merge this in unless you've got any other concerns

@hsheth2 hsheth2 merged commit 7c3ad3d into datahub-project:master Apr 8, 2022
maggiehays pushed a commit to maggiehays/datahub that referenced this pull request Aug 1, 2022
@ms32035 @hsheth2 @maggiehays
feat(ingest): enable connection string for all sqlalchemy datasources (…
0886be0 
…datahub-project#4508)

* feat(ingest): enable connection string for all sqlalchemy datasources

* Update sql_common.py

* fix types

* update docs

* rename variable to sqlalchemy_uri

Co-authored-by: Harshal Sheth <[email protected]>
@ms32035 ms32035 deleted the connect_uri branch April 8, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjoyce0510 jjoyce0510 jjoyce0510 left review comments

@hsheth2 hsheth2 hsheth2 approved these changes

Assignees

@hsheth2 hsheth2

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ms32035 @hsheth2 @jjoyce0510 @treff7es