Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ingestion): detect and disable telemetry in CI #4513

Merged
merged 4 commits into from
Mar 29, 2022

Conversation

kevinhu
Copy link
Contributor

@kevinhu kevinhu commented Mar 29, 2022

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@github-actions
Copy link

github-actions bot commented Mar 29, 2022

Unit Test Results (build & test)

  93 files  ±0    93 suites  ±0   21m 55s ⏱️ + 1m 18s
680 tests ±0  621 ✔️ ±0  59 💤 ±0  0 ±0 

Results for commit 0fa6a97. ± Comparison against base commit df69e76.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Mar 29, 2022

Unit Test Results (metadata ingestion)

       5 files  ±0         5 suites  ±0   59m 52s ⏱️ -10s
   388 tests ±0     388 ✔️ ±0    0 💤 ±0  0 ±0 
1 787 runs  ±0  1 749 ✔️  - 7  38 💤 +7  0 ±0 

Results for commit 0fa6a97. ± Comparison against base commit df69e76.

♻️ This comment has been updated with latest results.

@anshbansal
Copy link
Collaborator

Is this because it is causing problems in github actions? If yes, would it not be simpler to just edit the .github workflow files to set the env variable and disable telemetry?

@kevinhu
Copy link
Contributor Author

kevinhu commented Mar 29, 2022

Sort of-the issue here isn't our CI, but the possibility that we might be collecting data when users are invoking the ingestion pipeline in their own CI workflows. Since we can't expect people to always disable it themselves, we can instead try to detect it from these environment variables.

@jjoyce0510 jjoyce0510 merged commit 838982a into datahub-project:master Mar 29, 2022
maggiehays pushed a commit to maggiehays/datahub that referenced this pull request Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants