-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(metadata-service): Supporting a configurable Authorizer Chain #4584
Merged
jjoyce0510
merged 9 commits into
datahub-project:master
from
jjoyce0510:authorizer-chain
Apr 7, 2022
Merged
feat(metadata-service): Supporting a configurable Authorizer Chain #4584
jjoyce0510
merged 9 commits into
datahub-project:master
from
jjoyce0510:authorizer-chain
Apr 7, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metadata-service/auth-impl/src/main/java/com/datahub/authorization/AuthorizerChain.java
Outdated
Show resolved
Hide resolved
metadata-service/auth-impl/src/main/java/com/datahub/authorization/AuthorizerChain.java
Outdated
Show resolved
Hide resolved
dexter-mh-lee
approved these changes
Apr 5, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM just minor comments
maggiehays
pushed a commit
to maggiehays/datahub
that referenced
this pull request
Aug 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In this PR, we introduce support for a configurable Authorizer chain in the metadata service. This allows people to write their own implementation of the Authorizer interface and plug it in so that requests to perform specific actions can be authorized on DataHub using custom approaches.
Changes
Status
WIP
Checklist