fix(ingestion): ensure source/sink reports are always logged #4592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aditya-radhakrishnan
approved these changes
Apr 7, 2022
minor updates to language
jjoyce0510
approved these changes
Apr 8, 2022
jjoyce0510
reviewed
Apr 8, 2022
| pipeline.run() | ||
| logger.info("Finished metadata pipeline") | ||
| except Exception as e: | ||
| logger.error(f"Caught exception while running metadata ingestion: {e}") |
There was a problem hiding this comment.
Let's log the error and rethrow so that the process doesn't exit 0
There was a problem hiding this comment.
Also, we don't want to capture misconfigurations by the user in the telemetry. So, re-throwing is the right thing to do here.
There was a problem hiding this comment.
I did not want to lose pipeline.pretty_print_summary is the main reason I did not re-throw the exception. I pushed a change for non-zero return code. Let me know if that takes care of the concern.
anshbansal
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes the report does not get printed which makes it hard to debug problems. This should help with that.
Checklist