Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(snowflake): deprecate config, update examples #4644

Merged
merged 11 commits into from
Apr 20, 2022
Merged

fix(snowflake): deprecate config, update examples #4644

merged 11 commits into from
Apr 20, 2022

Conversation

anshbansal
Copy link
Collaborator

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@anshbansal anshbansal marked this pull request as draft April 12, 2022 12:25
@github-actions
Copy link

github-actions bot commented Apr 12, 2022 •
edited
Loading

Unit Test Results (build & test)

  97 files  ±0    97 suites  ±0   22m 45s ⏱️ + 6m 2s
701 tests ±0  642 ✔️ +14  59 💤  - 8  0 ❌  - 6 

Results for commit 4985ba2. ± Comparison against base commit 4b7f407.

♻️ This comment has been updated with latest results.

@anshbansal anshbansal mentioned this pull request Apr 12, 2022
Closed
5 tasks
@github-actions
Copy link

github-actions bot commented Apr 12, 2022 •
edited
Loading

Unit Test Results (metadata ingestion)

       5 files  ±  0         5 suites  ±0   1h 3m 51s ⏱️ + 3m 28s
   433 tests +  2     433 ✔️ +  7    0 💤 ±0  0 ❌ ±0 
2 090 runs  +10  2 044 ✔️ +15  46 💤 ±0  0 ❌ ±0 

Results for commit 4985ba2. ± Comparison against base commit 4b7f407.

♻️ This comment has been updated with latest results.

@anshbansal anshbansal marked this pull request as ready for review April 12, 2022 14:06
@anshbansal anshbansal closed this Apr 12, 2022
@anshbansal anshbansal reopened this Apr 12, 2022
@anshbansal anshbansal closed this Apr 13, 2022
@anshbansal anshbansal reopened this Apr 13, 2022
@anshbansal anshbansal closed this Apr 13, 2022
@anshbansal anshbansal reopened this Apr 13, 2022
@rslanka rslanka self-assigned this Apr 15, 2022
@rslanka rslanka changed the title chore(snowflake): deprecate config, update examples fix(snowflake): deprecate config, update examples Apr 20, 2022
rslanka
rslanka approved these changes Apr 20, 2022
View reviewed changes
Copy link
Contributor

@rslanka rslanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rslanka rslanka merged commit c66ef7c into datahub-project:master Apr 20, 2022
@anshbansal anshbansal deleted the chore-snowflake branch July 21, 2022 12:11
maggiehays pushed a commit to maggiehays/datahub that referenced this pull request Aug 1, 2022
@anshbansal @rslanka @maggiehays
fix(snowflake): deprecate config, update examples (datahub-project#4644)
48d0606 
* fix(snowflake): deprecate config, update examples

Co-authored-by: Ravindra Lanka <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rslanka rslanka rslanka approved these changes

Assignees

@rslanka rslanka

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anshbansal @rslanka