Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(glue): delete CatalogId parameter from get_jobs api call #4646

Merged
merged 4 commits into from
Apr 21, 2022
Merged

fix(glue): delete CatalogId parameter from get_jobs api call #4646

merged 4 commits into from
Apr 21, 2022

Conversation

BoyuanZhangDE
Copy link
Contributor

@BoyuanZhangDE BoyuanZhangDE commented Apr 12, 2022 •
edited
Loading

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@BoyuanZhangDE
glue-job-bug-fix
a511e13 
Delete the `CatalogId` parameter in get_jobs api call
@BoyuanZhangDE
Copy link
Contributor Author

BoyuanZhangDE commented Apr 12, 2022 •
edited
Loading

fix(glue): delete CatalogId parameter from get_jobs api call
delete CatalogId from get_jobs api call as it doesn't support this parameter. Also update the doc to notify users glue job doesn't support cross-account access at this moment
no BREAKING CHANGE

@github-actions
Copy link

github-actions bot commented Apr 12, 2022 •
edited
Loading

Unit Test Results (build & test)

  96 files  ±0    96 suites  ±0   23m 26s ⏱️ + 5m 32s
689 tests ±0  630 ✔️ ±0  59 💤 ±0  0 ❌ ±0 

Results for commit ea37058. ± Comparison against base commit 98d4fd4.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Apr 12, 2022 •
edited
Loading

Unit Test Results (metadata ingestion)

       5 files  ±0         5 suites  ±0   58m 55s ⏱️ - 9m 38s
   430 tests ±0     430 ✔️ ±0    0 💤 ±0  0 ❌ ±0 
2 075 runs  ±0  2 029 ✔️ ±0  46 💤 ±0  0 ❌ ±0 

Results for commit ea37058. ± Comparison against base commit 98d4fd4.

♻️ This comment has been updated with latest results.

treff7es
treff7es approved these changes Apr 21, 2022
View reviewed changes
Copy link
Contributor

@treff7es treff7es left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for the contribution!

@treff7es treff7es merged commit bbfc902 into datahub-project:master Apr 21, 2022
@mattmatravers mattmatravers mentioned this pull request Apr 21, 2022
Merged
@BoyuanZhangDE BoyuanZhangDE deleted the glue-job-bug-fix branch April 24, 2022 20:54
maggiehays pushed a commit to maggiehays/datahub that referenced this pull request Aug 1, 2022
@BoyuanZhangDE @maggiehays
fix(ingestion): glue - delete CatalogId parameter from get_jobs api c…
36dc52f 
…all (datahub-project#4646)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@treff7es treff7es treff7es approved these changes

Assignees

@treff7es treff7es

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BoyuanZhangDE @treff7es