Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sqlparser): fix sqlparser breaking due to # sign #4662

Merged
merged 3 commits into from
Apr 14, 2022
Merged

fix(sqlparser): fix sqlparser breaking due to # sign #4662

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2284343
fix(sqlparser): fix sqlparser breaking due to # sign
anshbansal Apr 13, 2022
8e6fdfb
Fix comments.
rslanka Apr 13, 2022
c3e0292
Move the test to the correct file.
rslanka Apr 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions metadata-ingestion/src/datahub/utilities/sql_lineage_parser_impl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,8 @@ def __init__(self, sql_query: str) -> None:
r"(\bdate\b)", rf"{self._DATE_SWAP_TOKEN}", sql_query, flags=re.IGNORECASE
)

sql_query = re.sub(r"#([^ ])", r"# \1", sql_query)

# SqlLineageParser lowercarese tablenames and we need to replace Looker specific token which should be uppercased
sql_query = re.sub(
rf"(\${{{self._MYVIEW_LOOKER_TOKEN}}})",
Expand Down
19 changes: 19 additions & 0 deletions metadata-ingestion/tests/unit/test_utilities.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -363,3 +363,22 @@ def test_sqllineage_sql_parser_tables_from_redash_query():
table_list = SqlLineageSQLParser(sql_query).get_tables()
table_list.sort()
assert table_list == ["order_items", "orders", "staffs"]


def test_hash_in_sql_query_with_no_space():
parser = SqlLineageSQLParser(
sql_query="""
/*
HERE IS A STANDARD COMMENT BLOCK
THIS WILL NOT BREAK sqllineage
*/
CREATE OR REPLACE TABLE `foo.bar.trg_tbl`AS
#This, comment will not break sqllineage
SELECT foo
-- this comment will not break sqllineage either
# this comment will not break sqllineage either
FROM `foo.bar.src_tbl`
"""
)

assert parser.get_tables() == ["foo.bar.src_tbl"]