Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lineage): Fix lineage entity drawer height UI bug #4707

Conversation

chriscollins3456
Copy link
Collaborator

When the width of a screen is small or an entity has enough path crumbs so that the browse path in the entity profile nav bar is wide enough to push content in this nav bar onto a second line, this second line gets covered up by the EntityDrawer that pops out from the left.

Since the EntityDrawer is an abolsutely positioned element and there's no easy way to contain it within its parent, we have to set the distance from the top of the page. In order to make this more dynamic for varying heights of EntityProfileNavBar I'm setting an empty div above the drawer and a ref on that div to get the offsetTop of it so we know how far to push down the drawer.

Here's the issue before the fix:
image

Here it is after the fix:
image

And it still looks good when it's only on one line:
image

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions
Copy link

Unit Test Results (build & test)

  97 files  ±0    97 suites  ±0   18m 1s ⏱️ - 11m 26s
701 tests ±0  642 ✔️ ±0  59 💤 ±0  0 ±0 

Results for commit c43611b. ± Comparison against base commit bb0a87a.

@jjoyce0510 jjoyce0510 merged commit c91d70f into datahub-project:master Apr 20, 2022
maggiehays pushed a commit to maggiehays/datahub that referenced this pull request Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants