Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(transformers): add snapshot aspects from dataset into base_transf… #4719

Conversation

shirshanka
Copy link
Contributor

…ormer

This registry was only set up for existing transformers in the code base, but fails for custom transformers written by other folks since it is not complete.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions
Copy link

Unit Test Results (build & test)

  97 files  ±0    97 suites  ±0   19m 14s ⏱️ +54s
701 tests ±0  642 ✔️ ±0  59 💤 ±0  0 ±0 

Results for commit 73f1b39. ± Comparison against base commit 9e30a9c.

@github-actions
Copy link

Unit Test Results (metadata ingestion)

       5 files  ±0         5 suites  ±0   59m 11s ⏱️ - 7m 2s
   433 tests ±0     433 ✔️ ±  0    0 💤 ±  0  0 ±0 
2 090 runs  ±0  2 044 ✔️ +20  46 💤  - 20  0 ±0 

Results for commit 73f1b39. ± Comparison against base commit 9e30a9c.

@gabe-lyons gabe-lyons merged commit 3353451 into datahub-project:master Apr 22, 2022
maggiehays pushed a commit to maggiehays/datahub that referenced this pull request Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants