Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ingest): remove new schema field usage #4987

Merged
merged 2 commits into from
May 24, 2022
Merged

fix(ingest): remove new schema field usage #4987

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
38afc22
fix(ingest): remove new schema field usage
anshbansal May 24, 2022
6f9c3ad
remove extra import
anshbansal May 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions metadata-ingestion/src/datahub/ingestion/source/sql/sql_common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,6 @@
ViewPropertiesClass,
)
from datahub.telemetry import telemetry
from datahub.utilities.mapping import Constants
from datahub.utilities.sqlalchemy_query_combiner import SQLAlchemyQueryCombinerReport

if TYPE_CHECKING:
Expand Down Expand Up @@ -1087,12 +1086,7 @@ def get_schema_fields_for_column(
tags: Optional[List[str]] = None,
) -> List[SchemaField]:
gtc: Optional[GlobalTagsClass] = None
is_partition_key: Optional[bool] = None
if tags:
if Constants.TAG_PARTITION_KEY in tags:
is_partition_key = True
else:
is_partition_key = False
tags_str = [make_tag_urn(t) for t in tags]
tags_tac = [TagAssociationClass(t) for t in tags_str]
gtc = GlobalTagsClass(tags_tac)
Expand All @@ -1104,7 +1098,6 @@ def get_schema_fields_for_column(
nullable=column["nullable"],
recursive=False,
globalTags=gtc,
isPartitioningKey=is_partition_key,
)
if (
pk_constraints is not None
Expand Down