-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(glossary) Display Incoming 'IsA' Glossary related entities #5063
feat(glossary) Display Incoming 'IsA' Glossary related entities #5063
Conversation
Just want to take the opportunity to clarify, to add relatedTerms to a term, we would still need to do ingestion via backend right? There is no way/plans to add via UI? |
@xiphl that is correct - for now! We recognize that that is desired and is scheduled as a followup to happen soon. So you should be able to Add/Delete Contains/Inherits relationships via the UI. |
This is highly needed from my side. Looking forward to it so i could let my data stewards work with business glossary independently and effectively via UI. Hope it will arrive soon! |
@@ -28,6 +28,19 @@ query getGlossaryTerm($urn: String!, $start: Int, $count: Int) { | |||
} | |||
} | |||
} | |||
childTerms: relationships(input: { types: ["IsA"], direction: INCOMING, start: $start, count: $count }) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor: This field may be confusing because there are technically both "IsA" and "HasA" children terms from this one.
Would it be clearer to say
isAChildren?
or
hasAChildren?
Just curious to hear your thoughts. We are also okay to do this as a followup
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah that makes sense - I think isAChildren
for this case is pretty understandable and clear - will make a quick change and push up
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM
d9f5ae1
to
243e617
Compare
Will merge once CI passes. |
…hub-project#5063) * feat(glossary) Display Incoming 'IsA' Glossary related entities * update name of field Co-authored-by: Chris Collins <[email protected]> Co-authored-by: Chris Collins <[email protected]>
Now displays related entities that are related to any Incoming "IsA" glossary terms on a parent term's related entities tab.
For example:
TermA inherits from TermB (TermA has an Outgoing "IsA" relationship defined with TermA) and therefore shows TermA in its Inherits tab. If you go to TermB's profile, you will see all entities related to TermA in TermB's Related Entities tab.
The way the the Related Terms tab works, though, is that we only show Outgoing "IsA" and "HasA" relationships (Inherits and Contains, respectively). So TermB may not show TermA in its Related Terms tab.
Note: This is only 1 level down, so we only show direct Incoming "IsA" relationship children's related entities (much easier and quicker to implement than going all the way through the tree)
A visual example -
Container Term
has two Incoming "IsA" relationships withChild Term
and2nd Child Term
and therefore will show all of their related entities in its own tab as well as its own.Checklist