Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(restore-indices): Do not fail while working with each row #5084

Merged
merged 2 commits into from
Jun 3, 2022
Merged

fix(restore-indices): Do not fail while working with each row #5084

merged 2 commits into from
Jun 3, 2022

Conversation

dexter-mh-lee
Copy link
Contributor

Instead log error and move on.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions
Copy link

github-actions bot commented Jun 3, 2022 •
edited
Loading

Unit Test Results (build & test)

334 tests  ±0   334 ✔️ ±0   3m 1s ⏱️ -1s
  78 suites ±0       0 💤 ±0 
  78 files   ±0       0 ❌ ±0 

Results for commit 59f925c. ± Comparison against base commit 4da3d13.

♻️ This comment has been updated with latest results.

jjoyce0510
jjoyce0510 approved these changes Jun 3, 2022
View reviewed changes
Copy link
Collaborator

@jjoyce0510 jjoyce0510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving but why do we needthis?

@RyanHolstien
Copy link
Collaborator

Approving but why do we needthis?

https://datahubspace.slack.com/archives/C029A3M079U/p1654279575039019

@dexter-mh-lee dexter-mh-lee merged commit 59d33ca into datahub-project:master Jun 3, 2022
@dexter-mh-lee dexter-mh-lee deleted the dl--restore-indices-less-failure branch June 3, 2022 21:11
maggiehays pushed a commit to maggiehays/datahub that referenced this pull request Aug 1, 2022
@maggiehays
fix(restore-indices): Do not fail while working with each row (datahu…
a6aaa3d 
…b-project#5084)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjoyce0510 jjoyce0510 jjoyce0510 approved these changes

@RyanHolstien RyanHolstien RyanHolstien approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dexter-mh-lee @RyanHolstien @jjoyce0510