Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(docs): ingest - add tab for config json schema #5086

Merged
merged 2 commits into from
Jun 3, 2022
Merged

feat(docs): ingest - add tab for config json schema #5086

merged 2 commits into from
Jun 3, 2022

Conversation

shirshanka
Copy link
Contributor

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@shirshanka
Copy link
Contributor Author

Screen Shot 2022-06-03 at 1 18 40 PM

@shirshanka
Copy link
Contributor Author

Screen Shot 2022-06-03 at 1 18 36 PM

@github-actions
Copy link

github-actions bot commented Jun 3, 2022 •
edited
Loading

Unit Test Results (build & test)

334 tests   334 ✔️  2m 48s ⏱️
  78 suites      0 💤
  78 files        0 ❌

Results for commit 1993f00.

♻️ This comment has been updated with latest results.

@shirshanka shirshanka force-pushed the docs-config-schema branch from cee3e97 to 1993f00 Compare June 3, 2022 21:08
swaroopjagadish
swaroopjagadish approved these changes Jun 3, 2022
View reviewed changes
Copy link
Contributor

@swaroopjagadish swaroopjagadish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@swaroopjagadish swaroopjagadish merged commit 64fae61 into datahub-project:master Jun 3, 2022
maggiehays pushed a commit to maggiehays/datahub that referenced this pull request Aug 1, 2022
@shirshanka @maggiehays
feat(docs): ingest - add tab for config json schema (datahub-project#…
7f5e9ea 
…5086)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swaroopjagadish swaroopjagadish swaroopjagadish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shirshanka @swaroopjagadish