Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(doc): Generating json schema for ingestion recipes #5092

Merged
merged 2 commits into from
Jun 6, 2022
Merged

feat(doc): Generating json schema for ingestion recipes #5092

merged 2 commits into from
Jun 6, 2022

Conversation

treff7es
Copy link
Contributor

@treff7es treff7es commented Jun 5, 2022

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions
Copy link

github-actions bot commented Jun 5, 2022 •
edited
Loading

Unit Test Results (build & test)

334 tests  ±0   334 ✔️ ±0   3m 36s ⏱️ +21s
  78 suites ±0       0 💤 ±0 
  78 files   ±0       0 ❌ ±0 

Results for commit 043bbd6. ± Comparison against base commit e62c647.

♻️ This comment has been updated with latest results.

shirshanka
shirshanka approved these changes Jun 6, 2022
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@treff7es treff7es merged commit b737df6 into datahub-project:master Jun 6, 2022
maggiehays pushed a commit to maggiehays/datahub that referenced this pull request Aug 1, 2022
@treff7es @maggiehays
feat(doc): Generating json schema for ingestion recipes (datahub-proj…
fc7fc8a 
…ect#5092)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirshanka shirshanka shirshanka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@treff7es @shirshanka